urgent bugfix 2.5.4 added missing CSS fix, ready for release?

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2474039 b8457f37-d9ea-0310-8a92-e5e31aec5664
This commit is contained in:
pewgeuges 2021-02-12 23:15:02 +00:00
parent e328969abf
commit cc52be66fa
3 changed files with 143 additions and 123 deletions

View file

@ -5,43 +5,39 @@
* Created-Time: 16:21 * Created-Time: 16:21
* Since: 1.0 * Since: 1.0
*/ */
/*<?php for docblocks
/* Version: 2.5.4 /**
* @version 2.5.4
Last modified: 2021-02-12T1709+0100 * @lastmodified 2021-02-13T0004+0100
*
* Classes recommended for Custom CSS:
* @see templates/dashboard/customize-css-new.html
*
* @since 2.0.0 Referrers: vertical align: lower from top: 0.4em to top: 0.6em
* @since 2.0.0 Tooltips: Font size: set to inherit instead of 13px
* @since 2.0.0 Tooltips: Continue button: apply distinctive font color and font style
* @since 2.0.0 Tooltips: fix bug displaying content inline when page is printed, thanks to @gernsheim bug report
* @since 2.0.0 Reference container: Collapse button: fix text decoration
* @since 2.0.1 enforce borderless table cells through !important property, thanks to @ragonesi bug report
* @since 2.1.1 Referrers: line height 0 to fix superscript, thanks to @cwbayer bug report
* @since 2.1.1 Bugfix: Tooltips: fix line breaking for hyperlinked URLs in Unicode-non-compliant user agents, thanks to @andreasra bug report.
* @since 2.1.6 set z-index to maximum 2147483647 to address display issues with overlay content, thanks to @russianicons bug report
* @since 2.3.0 offset anchors for optional hard links, thanks to @psychonevro @martinneumannat bug reports
* @since 2.4.0 validation error warning box
* @since 2.5.0 validation error warning box more paragraphs
*/
Classes recommended for Custom CSS are listed in /**
templates/dashboard/customize-css-new.html * MCI Footnotes logo
*
* The classes with 'heading' fix display in dashboard,
Edited: * where since WordPress 5.5 settings box labels with
* spans are displayed as justified not last line.
@since 2.0.0 Referrers: vertical align: lower from top: 0.4em to top: 0.6em *
@since 2.0.0 Tooltips: Font size: set to inherit instead of 13px * @see class/config.php
@since 2.0.0 Tooltips: Continue button: apply distinctive font color and font style * @see css/settings.css
@since 2.0.0 Tooltips: fix bug displaying content inline when page is printed, thanks to @gernsheim bug report */
@since 2.0.0 Reference container: Collapse button: fix text decoration
@since 2.0.1 enforce borderless table cells through !important property, thanks to @ragonesi bug report
@since 2.1.1 Referrers: line height 0 to fix superscript, thanks to @cwbayer bug report
@since 2.1.1 Bugfix: Tooltips: fix line breaking for hyperlinked URLs in Unicode-non-compliant user agents, thanks to @andreasra bug report.
@since 2.1.6 set z-index to maximum 2147483647 to address display issues with overlay content, thanks to @russianicons bug report
@since 2.3.0 offset anchors for optional hard links, thanks to @psychonevro @martinneumannat bug reports
@since 2.4.0 validation error warning box
@since 2.5.0 validation error warning box more paragraphs
*/
/*****************************************************
MCI Footnotes logo
The classes with 'heading' fix display in dashboard,
where since WordPress 5.5 settings box labels with
spans are displayed as justified and not last line.
class/config.php
css/settings.css
*/
.footnotes_logo, .footnotes_logo,
.footnotes_logo:hover, .footnotes_logo:hover,
@ -60,21 +56,21 @@ css/settings.css
color: #545f5a; color: #545f5a;
} }
/***************************************************** /**
Validation error warning displayed below post title * Validation error warning displayed below post title
*
The presence of unbalanced footnote start short codes * The presence of unbalanced footnote start short codes
significantly alters the post display and may cause an * significantly alters the post display and may cause an
issue with missing content or footnotes, while it may * issue with missing content or footnotes, while it may
be hard to detect in long posts and under deadline. * be hard to detect in long posts and under deadline.
*
A validation check displays a warning box below the * A validation check displays a warning box below the
post title, populated with 300 characters of content * post title, populated with 300 characters of content
preceded by the first unbalanced start tag short code. * preceded by the first unbalanced start tag short code.
*
@since 2.4.0 * @since 2.4.0
@since 2.5.0 improvement increased paragraph number * @since 2.5.0 improvement increased paragraph number
*/ */
.footnotes_validation_error { .footnotes_validation_error {
border: 4px solid red; border: 4px solid red;
@ -104,54 +100,60 @@ preceded by the first unbalanced start tag short code.
font-size: 12px; font-size: 12px;
} }
/***************************************************** /**
Long URLs in Unicode-non-compliant user agents * Long URLs in Unicode-non-compliant user agents
*
Unicode recommends to break URLs at slashes, but * Unicode recommends to break URLs at slashes, but
some browsers dont, so we need to prevent URLs * some browsers dont, so we need to prevent URLs
from expanding the reference container in mobile view, * from expanding the reference container in mobile view,
or from hanging out of the tooltip even on desktop. * or from hanging out of the tooltip even on desktop.
*
Based on pattern, not link element, since some URLs * Based on pattern, not link element, since some URLs
are not hyperlinked, while often the hyperlink text * are not hyperlinked, while often the hyperlink text
is common language, that mustnt be broken anywhere. * is common language, that mustnt be broken anywhere.
*
class/task.php * @see class/task.php
*
These rules arent cross-browser compatible: * These rules arent cross-browser compatible:
word-break: break-word; * word-break: break-word;
overflow-wrap: anywhere; * overflow-wrap: anywhere;
word-wrap: anywhere; * word-wrap: anywhere;
word-break: break-all; * word-break: break-all;
*
These rules turn out useless for the purpose and are commented out: * These rules turn out useless for the purpose and are commented out:
word-wrap: break-word; * word-wrap: break-word;
overflow-wrap: break-word; * overflow-wrap: break-word;
*
*
- Bugfix: Reference container, tooltips: URL wrap: enable the 'word-wrap: anywhere' rule, thanks to @rebelc0de bug report. * - Bugfix: Reference container, tooltips: URL wrap: enable the 'word-wrap: anywhere' rule, thanks to @rebelc0de bug report.
*
@since 2.5.4 * @since 2.5.4
*
@reporter @rebelc0de * @reporter @rebelc0de
@link https://wordpress.org/support/topic/footnotes-on-mobile-phones/#post-14037101 * @link https://wordpress.org/support/topic/footnotes-on-mobile-phones/#post-14037101
*/ */
.footnote_url_wrap { .footnote_url_wrap {
word-wrap: anywhere; word-wrap: anywhere;
overflow-wrap: anywhere; overflow-wrap: anywhere;
word-break: break-all; word-break: break-all;
} }
/***************************************************** /**
Optional hard links * Optional hard links: anchors with scroll offset
*
Anchors with scroll offset * - Adding: Referrers and backlinks: optional hard links for AMP compatibility, thanks to @psykonevro bug report, thanks to @martinneumannat code contribution.
*
@since 2.3.0 offset anchors for optional hard links, thanks to @psychonevro @martinneumannat bug reports * @since 2.3.0
@see <https://wordpress.org/support/topic/making-it-amp-compatible/> * @contributor @martinneumannat
@see <https://wordpress.org/support/topic/footnotes-is-not-amp-compatible/> * @link https://wordpress.org/support/topic/making-it-amp-compatible/
*/ * @reporter @psychonevro
* @link https://wordpress.org/support/topic/footnotes-is-not-amp-compatible/
*
* Although often skipped as unstraightforward, or believed impossible,
* an offset hard link anchor can be coded out of a fragment identifier
* span with absolute position nested in a span with relative position.
*/
.footnote_item_base, .footnote_item_base,
.footnote_referrer_base { .footnote_referrer_base {
@ -163,21 +165,16 @@ Anchors with scroll offset
position: relative; position: relative;
} }
/***************************************************** /**
Footnote referrers and tooltips * Footnote referrers and tooltips
*
Templates: * @see templates/public/footnote.html
templates/public/footnote.html * @see templates/public/footnote-alternative.html
templates/public/footnote-alternative.html *
* .footnote_referrer = enclosing <span>
Classes: * .footnote_plugin_tooltip_text = inner <sup>
.footnote_referrer = enclosing <span> * .footnote_tooltip = inner <span>
.footnote_plugin_tooltip_text = inner <sup> */
.footnote_tooltip = inner <span>
@since 2.1.1 Referrers: line height 0 to fix superscript, thanks to @cwbayer bug report
@see <https://wordpress.org/support/topic/footnote-number-in-text-superscript-disrupts-leading/>
*/
.footnote_referrer, .footnote_referrer,
.footnote_referrer:link, .footnote_referrer:link,
@ -200,17 +197,37 @@ Classes:
box-shadow: none !important; box-shadow: none !important;
} }
/**
* Footnote referrer (not tooltip text)
*
* - Bugfix: Referrers: line height 0 to fix superscript, thanks to @cwbayer bug report.
*
* @since 2.1.1
* @reporter @cwbayer
* @link https://wordpress.org/support/topic/footnote-number-in-text-superscript-disrupts-leading/
*
* - Bugfix: Tooltips: fix jQuery positioning bug moving tooltips out of view and affecting (TablePress tables in) some themes, thanks to @wisenilesh bug report.
*
* @since 2.5.4
* @reporter @wisenilesh
* @link https://wordpress.org/support/topic/footnotes-not-working-properly-inside-the-tables-of-tablepress-plugin/
*/
.footnote_plugin_tooltip_text { .footnote_plugin_tooltip_text {
line-height: 0; line-height: 0;
position: relative !important;
cursor: pointer; cursor: pointer;
} }
/* /**
tooltips * Tooltips
*
@since 2.1.6 set z-index to maximum 2147483647 to address display issues with overlay content, thanks to @russianicons bug report * - Bugfix: Tooltips: set z-index to maximum 2147483647 to address display issues with overlay content, thanks to @russianicons bug report.
@see <https://wordpress.org/support/topic/counter-styles-not-working/#post-13767299> *
*/ * @since 2.1.6
* @reporter @russianicons
* @link https://wordpress.org/support/topic/counter-styles-not-working/#post-13767299
*/
.footnote_tooltip { .footnote_tooltip {
display: none; display: none;
@ -223,9 +240,11 @@ tooltips
font-style: normal; font-style: normal;
} }
/* /**
alternative tooltip implementation * Alternative tooltips
*/ *
* These default position values may be overridden by internal CSS.
*/
.footnote_referrer.relative { .footnote_referrer.relative {
position: relative; position: relative;

View file

@ -81,6 +81,7 @@ Visit this swift write-up from a **footnotes** user by the name of **Southwest**
= 2.5.4 = = 2.5.4 =
- Bugfix: Referrers: optional fixes to vertical alignment, font size and position (static) for in-theme consistency and cross-theme stability, thanks to @tomturowski bug report. - Bugfix: Referrers: optional fixes to vertical alignment, font size and position (static) for in-theme consistency and cross-theme stability, thanks to @tomturowski bug report.
- Bugfix: Tooltips: fix jQuery positioning bug moving tooltips out of view and affecting (TablePress tables in) some themes, thanks to @wisenilesh bug report.
- Bugfix: Reference container, tooltips: URL wrap: enable the 'word-wrap: anywhere' rule, thanks to @rebelc0de bug report. - Bugfix: Reference container, tooltips: URL wrap: enable the 'word-wrap: anywhere' rule, thanks to @rebelc0de bug report.
- Bugfix: Reference container, tooltips: URL wrap: account for leading space in value, thanks to @karolszakiel example provision. - Bugfix: Reference container, tooltips: URL wrap: account for leading space in value, thanks to @karolszakiel example provision.
- Bugfix: Dashboard: Tooltip dimensions: move from 'Tooltip position' to a dedicated metabox, thanks to @codldmac issue report. - Bugfix: Dashboard: Tooltip dimensions: move from 'Tooltip position' to a dedicated metabox, thanks to @codldmac issue report.

View file

@ -4,6 +4,10 @@
<td>[[label-superscript]]</td> <td>[[label-superscript]]</td>
<td>[[superscript]]</td> <td>[[superscript]]</td>
</tr> </tr>
<tr>
<td>[[label-normalize]]</td>
<td>[[normalize]] <span class="footnotes_notice">[[notice-normalize]]</span></td>
</tr>
<tr> <tr>
<td>[[label-before]]</td> <td>[[label-before]]</td>
<td>[[before]]</td> <td>[[before]]</td>
@ -16,9 +20,5 @@
<td>[[label-link]]</td> <td>[[label-link]]</td>
<td><span class="footnotes_notice">[[notice-link]]</span></td> <td><span class="footnotes_notice">[[notice-link]]</span></td>
</tr> </tr>
<tr>
<td>[[label-normalize]]</td>
<td>[[normalize]] <span class="footnotes_notice">[[notice-normalize]]</span></td>
</tr>
</tbody> </tbody>
</table> </table>