From cc52be66fa0a44338ba6c537894a35e1a218ae14 Mon Sep 17 00:00:00 2001
From: pewgeuges <73141620+pewgeuges@users.noreply.github.com>
Date: Fri, 12 Feb 2021 23:15:02 +0000
Subject: [PATCH] urgent bugfix 2.5.4 added missing CSS fix, ready for release?

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2474039 b8457f37-d9ea-0310-8a92-e5e31aec5664
---
 css/public.css                                | 257 ++++++++++--------
 readme.txt                                    |   1 +
 .../dashboard/customize-superscript.html      |   8 +-
 3 files changed, 143 insertions(+), 123 deletions(-)

diff --git a/css/public.css b/css/public.css
index dec5f67..aa34751 100755
--- a/css/public.css
+++ b/css/public.css
@@ -5,43 +5,39 @@
  * Created-Time: 16:21
  * Since: 1.0
  */
-
-/* Version: 2.5.4
-
-Last modified: 2021-02-12T1709+0100
+/*<?php for docblocks
+/**
+ * @version 2.5.4
+ * @lastmodified 2021-02-13T0004+0100
+ *
+ *     Classes recommended for Custom CSS:
+ *     @see templates/dashboard/customize-css-new.html
+ *
+ * @since 2.0.0  Referrers: vertical align: lower from top: 0.4em to top: 0.6em
+ * @since 2.0.0  Tooltips: Font size: set to inherit instead of 13px
+ * @since 2.0.0  Tooltips: Continue button: apply distinctive font color and font style
+ * @since 2.0.0  Tooltips: fix bug displaying content inline when page is printed, thanks to @gernsheim bug report
+ * @since 2.0.0  Reference container: Collapse button: fix text decoration
+ * @since 2.0.1  enforce borderless table cells through !important property, thanks to @ragonesi bug report
+ * @since 2.1.1  Referrers: line height 0 to fix superscript, thanks to @cwbayer bug report
+ * @since 2.1.1  Bugfix: Tooltips: fix line breaking for hyperlinked URLs in Unicode-non-compliant user agents, thanks to @andreasra bug report.
+ * @since 2.1.6  set z-index to maximum 2147483647 to address display issues with overlay content, thanks to @russianicons bug report
+ * @since 2.3.0  offset anchors for optional hard links, thanks to @psychonevro @martinneumannat bug reports
+ * @since 2.4.0  validation error warning box
+ * @since 2.5.0  validation error warning box more paragraphs
+ */
 
 
-        Classes recommended for Custom CSS are listed in
-        templates/dashboard/customize-css-new.html
-
-
-Edited:
-
-@since 2.0.0  Referrers: vertical align: lower from top: 0.4em to top: 0.6em
-@since 2.0.0  Tooltips: Font size: set to inherit instead of 13px
-@since 2.0.0  Tooltips: Continue button: apply distinctive font color and font style
-@since 2.0.0  Tooltips: fix bug displaying content inline when page is printed, thanks to @gernsheim bug report
-@since 2.0.0  Reference container: Collapse button: fix text decoration
-@since 2.0.1  enforce borderless table cells through !important property, thanks to @ragonesi bug report
-@since 2.1.1  Referrers: line height 0 to fix superscript, thanks to @cwbayer bug report
-@since 2.1.1  Bugfix: Tooltips: fix line breaking for hyperlinked URLs in Unicode-non-compliant user agents, thanks to @andreasra bug report.
-@since 2.1.6  set z-index to maximum 2147483647 to address display issues with overlay content, thanks to @russianicons bug report
-@since 2.3.0  offset anchors for optional hard links, thanks to @psychonevro @martinneumannat bug reports
-@since 2.4.0  validation error warning box
-@since 2.5.0  validation error warning box more paragraphs
-*/
-
-
-/*****************************************************
-MCI Footnotes logo
-
-The classes with 'heading' fix display in dashboard,
-where since WordPress 5.5 settings box labels with
-spans are displayed as justified and not last line.
-
-class/config.php
-css/settings.css
-*/
+/**
+ * MCI Footnotes logo
+ *
+ * The classes with 'heading' fix display in dashboard,
+ * where since WordPress 5.5 settings box labels with
+ * spans are displayed as justified not last line.
+ *
+ * @see class/config.php
+ * @see css/settings.css
+ */
 
 .footnotes_logo,
 .footnotes_logo:hover,
@@ -60,21 +56,21 @@ css/settings.css
     color: #545f5a;
 }
 
-/*****************************************************
-Validation error warning displayed below post title
-
-The presence of unbalanced footnote start short codes
-significantly alters the post display and may cause an
-issue with missing content or footnotes, while it may
-be hard to detect in long posts and under deadline.
-
-A validation check displays a warning box below the
-post title, populated with 300 characters of content
-preceded by the first unbalanced start tag short code.
-
-@since 2.4.0
-@since 2.5.0  improvement increased paragraph number
-*/
+/**
+ * Validation error warning displayed below post title
+ *
+ * The presence of unbalanced footnote start short codes
+ * significantly alters the post display and may cause an
+ * issue with missing content or footnotes, while it may
+ * be hard to detect in long posts and under deadline.
+ *
+ * A validation check displays a warning box below the
+ * post title, populated with 300 characters of content
+ * preceded by the first unbalanced start tag short code.
+ *
+ * @since 2.4.0
+ * @since 2.5.0  improvement increased paragraph number
+ */
 
 .footnotes_validation_error {
     border: 4px solid red;
@@ -104,54 +100,60 @@ preceded by the first unbalanced start tag short code.
     font-size: 12px;
 }
 
-/*****************************************************
-Long URLs in Unicode-non-compliant user agents
-
-Unicode recommends to break URLs at slashes, but
-some browsers don’t, so we need to prevent URLs
-from expanding the reference container in mobile view,
-or from hanging out of the tooltip even on desktop.
-
-Based on pattern, not link element, since some URLs
-are not hyperlinked, while often the hyperlink text
-is common language, that mustn’t be broken anywhere.
-
-class/task.php
-
-These rules aren’t cross-browser compatible:
-word-break: break-word;
-overflow-wrap: anywhere;
-word-wrap: anywhere;
-word-break: break-all;
-
-These rules turn out useless for the purpose and are commented out:
-word-wrap: break-word;
-overflow-wrap: break-word;
-
-
-- Bugfix: Reference container, tooltips: URL wrap: enable the 'word-wrap: anywhere' rule, thanks to @rebelc0de bug report.
-
-@since 2.5.4
-
-@reporter @rebelc0de
-@link https://wordpress.org/support/topic/footnotes-on-mobile-phones/#post-14037101
-*/
+/**
+ * Long URLs in Unicode-non-compliant user agents
+ *
+ * Unicode recommends to break URLs at slashes, but
+ * some browsers don’t, so we need to prevent URLs
+ * from expanding the reference container in mobile view,
+ * or from hanging out of the tooltip even on desktop.
+ *
+ * Based on pattern, not link element, since some URLs
+ * are not hyperlinked, while often the hyperlink text
+ * is common language, that mustn’t be broken anywhere.
+ *
+ * @see class/task.php
+ *
+ * These rules aren’t cross-browser compatible:
+ * word-break: break-word;
+ * overflow-wrap: anywhere;
+ * word-wrap: anywhere;
+ * word-break: break-all;
+ *
+ * These rules turn out useless for the purpose and are commented out:
+ * word-wrap: break-word;
+ * overflow-wrap: break-word;
+ *
+ *
+ * - Bugfix: Reference container, tooltips: URL wrap: enable the 'word-wrap: anywhere' rule, thanks to @rebelc0de bug report.
+ *
+ * @since 2.5.4
+ *
+ * @reporter @rebelc0de
+ * @link https://wordpress.org/support/topic/footnotes-on-mobile-phones/#post-14037101
+ */
 
 .footnote_url_wrap {
-	word-wrap: anywhere;
-	overflow-wrap: anywhere;
-	word-break: break-all;
+    word-wrap: anywhere;
+    overflow-wrap: anywhere;
+    word-break: break-all;
 }
 
-/*****************************************************
-Optional hard links
-
-Anchors with scroll offset
-
-@since 2.3.0  offset anchors for optional hard links, thanks to @psychonevro @martinneumannat bug reports
-@see <https://wordpress.org/support/topic/making-it-amp-compatible/>
-@see <https://wordpress.org/support/topic/footnotes-is-not-amp-compatible/>
-*/
+/**
+ * Optional hard links: anchors with scroll offset
+ *
+ * - Adding: Referrers and backlinks: optional hard links for AMP compatibility, thanks to @psykonevro bug report, thanks to @martinneumannat code contribution.
+ *
+ * @since 2.3.0
+ * @contributor @martinneumannat
+ * @link https://wordpress.org/support/topic/making-it-amp-compatible/
+ * @reporter @psychonevro
+ * @link https://wordpress.org/support/topic/footnotes-is-not-amp-compatible/
+ *
+ * Although often skipped as unstraightforward, or believed impossible,
+ * an offset hard link anchor can be coded out of a fragment identifier
+ * span with absolute position nested in a span with relative position.
+ */
 
 .footnote_item_base,
 .footnote_referrer_base {
@@ -163,21 +165,16 @@ Anchors with scroll offset
     position: relative;
 }
 
-/*****************************************************
-Footnote referrers and tooltips
-
-Templates:
-templates/public/footnote.html
-templates/public/footnote-alternative.html
-
-Classes:
-.footnote_referrer            = enclosing <span>
-.footnote_plugin_tooltip_text = inner <sup>
-.footnote_tooltip             = inner <span>
-
-@since 2.1.1  Referrers: line height 0 to fix superscript, thanks to @cwbayer bug report
-@see <https://wordpress.org/support/topic/footnote-number-in-text-superscript-disrupts-leading/>
-*/
+/**
+ * Footnote referrers and tooltips
+ *
+ * @see templates/public/footnote.html
+ * @see templates/public/footnote-alternative.html
+ *
+ * .footnote_referrer            = enclosing <span>
+ * .footnote_plugin_tooltip_text = inner <sup>
+ * .footnote_tooltip             = inner <span>
+ */
 
 .footnote_referrer,
 .footnote_referrer:link,
@@ -200,17 +197,37 @@ Classes:
     box-shadow: none !important;
 }
 
+/**
+ * Footnote referrer (not “tooltip text”)
+ *
+ * - Bugfix: Referrers: line height 0 to fix superscript, thanks to @cwbayer bug report.
+ *
+ * @since 2.1.1
+ * @reporter @cwbayer
+ * @link https://wordpress.org/support/topic/footnote-number-in-text-superscript-disrupts-leading/
+ *
+ * - Bugfix: Tooltips: fix jQuery positioning bug moving tooltips out of view and affecting (TablePress tables in) some themes, thanks to @wisenilesh bug report.
+ *
+ * @since 2.5.4
+ * @reporter @wisenilesh
+ * @link https://wordpress.org/support/topic/footnotes-not-working-properly-inside-the-tables-of-tablepress-plugin/
+ */
+
 .footnote_plugin_tooltip_text {
-    line-height: 0;
+	line-height: 0;
+    position: relative !important;
     cursor: pointer;
 }
 
-/*
-tooltips
-
-@since 2.1.6  set z-index to maximum 2147483647 to address display issues with overlay content, thanks to @russianicons bug report
-@see <https://wordpress.org/support/topic/counter-styles-not-working/#post-13767299>
-*/
+/**
+ * Tooltips
+ * 
+ * - Bugfix: Tooltips: set z-index to maximum 2147483647 to address display issues with overlay content, thanks to @russianicons bug report.
+ * 
+ * @since 2.1.6
+ * @reporter @russianicons
+ * @link https://wordpress.org/support/topic/counter-styles-not-working/#post-13767299
+ */
 
 .footnote_tooltip {
     display: none;
@@ -223,9 +240,11 @@ tooltips
     font-style: normal;
 }
 
-/*
-alternative tooltip implementation
-*/
+/**
+ * Alternative tooltips
+ * 
+ * These default position values may be overridden by internal CSS.
+ */
 
 .footnote_referrer.relative {
     position: relative;
diff --git a/readme.txt b/readme.txt
index b7a6260..f34e092 100755
--- a/readme.txt
+++ b/readme.txt
@@ -81,6 +81,7 @@ Visit this swift write-up from a **footnotes** user by the name of **Southwest**
 
 = 2.5.4 =
 - Bugfix: Referrers: optional fixes to vertical alignment, font size and position (static) for in-theme consistency and cross-theme stability, thanks to @tomturowski bug report.
+- Bugfix: Tooltips: fix jQuery positioning bug moving tooltips out of view and affecting (TablePress tables in) some themes, thanks to @wisenilesh bug report.
 - Bugfix: Reference container, tooltips: URL wrap: enable the 'word-wrap: anywhere' rule, thanks to @rebelc0de bug report.
 - Bugfix: Reference container, tooltips: URL wrap: account for leading space in value, thanks to @karolszakiel example provision.
 - Bugfix: Dashboard: Tooltip dimensions: move from 'Tooltip position' to a dedicated metabox, thanks to @codldmac issue report.
diff --git a/templates/dashboard/customize-superscript.html b/templates/dashboard/customize-superscript.html
index e3a0333..a29313a 100644
--- a/templates/dashboard/customize-superscript.html
+++ b/templates/dashboard/customize-superscript.html
@@ -4,6 +4,10 @@
             <td>[[label-superscript]]</td>
             <td>[[superscript]]</td>
         </tr>
+        <tr>
+            <td>[[label-normalize]]</td>
+            <td>[[normalize]] <span class="footnotes_notice">[[notice-normalize]]</span></td>
+        </tr>
         <tr>
             <td>[[label-before]]</td>
             <td>[[before]]</td>
@@ -16,9 +20,5 @@
             <td>[[label-link]]</td>
             <td><span class="footnotes_notice">[[notice-link]]</span></td>
         </tr>
-        <tr>
-            <td>[[label-normalize]]</td>
-            <td>[[normalize]] <span class="footnotes_notice">[[notice-normalize]]</span></td>
-        </tr>
     </tbody>
 </table>