chore: lint code

Fix #189

.github/workflows/pre-release.yml

@@ -1,53 +0,0 @@
-name: Pre-release Handler
-
-on:
-  release:
-    types: [published]
-
-jobs:
-  build:
-    name: Build the Plugin for pre-release
-    if: "github.event.release.prerelease"
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v2
-
-      - name: Install dependencies
-        run: |
-          composer install --no-dev --optimize-autoloader --no-progress
-          
-      - name: Build Plugin
-        run: |
-          composer run build
-          
-      - name: Rename dist/ folder
-        run: |
-          mv dist/ footnotes/
-
-      - name: Create release archive
-        uses: montudor/action-zip@v0.1.0
-        with:
-          args: zip -X -r footnotes-${{ github.event.release.tag_name }}.zip footnotes
-
-      - name: Upload archive as artifact
-        uses: actions/upload-artifact@v2
-        with:
-            name: footnotes-${{ github.event.release.tag_name }}
-            path: footnotes-${{ github.event.release.tag_name }}.zip
-            
-      - name: Upload archive to release
-        uses: JasonEtco/upload-to-release@master
-        with:
-          args: footnotes-${{ github.event.release.tag_name }}.zip application/zip
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-      #- name: Deploy release to Wordpress.org 
-      #  uses: 10up/action-wordpress-plugin-deploy@stable
-      #  with:
-      #    generate-zip: true
-      #  env:
-      #    SVN_USERNAME: ${{ secrets.SVN_USERNAME }}
-      #    SVN_PASSWORD: ${{ secrets.SVN_PASSWORD }}

.github/workflows/release-handler.yml

@@ -0,0 +1,87 @@
+# This workflow handles GitHub releases and pre-releases.
+# It builds the Plugin, zips up an archive to add to the
+# release entry on GitHub and (in the case of a full release)
+# pushes the release to the WP Plugin Directory SVN repo.
+
+name: Release Handler
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  build_plugin:
+    name: Build the Plugin for pre-release
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Install dependencies
+        run: |
+          composer install --no-dev --optimize-autoloader --no-progress
+          
+      - name: Build Plugin
+        run: |
+          composer run build
+
+      - name: Rename Plugin folder
+        run: |
+          mv dist/ footnotes/
+          
+      - name: Upload Plugin artifact
+        uses: actions/upload-artifact@v2
+        with:
+          name: footnotes-${{ github.event.release.tag_name }}
+          path: footnotes
+
+  create_archive:
+    name: Create an archive for the release and add it to GitHub
+    runs-on: ubuntu-latest
+    needs: build_plugin
+
+    steps:
+      - name: Download Plugin artifact
+        uses: actions/download-artifact@v2
+        with:
+          name: footnotes-${{ github.event.release.tag_name }}
+
+      - name: Create release archive
+        uses: montudor/action-zip@v0.1.0
+        with:
+          args: zip -X -r footnotes-${{ github.event.release.tag_name }}.zip footnotes
+
+      #- name: Upload archive as artifact
+      #  uses: actions/upload-artifact@v2
+      #  with:
+      #      name: footnotes-${{ github.event.release.tag_name }}
+      #      path: footnotes-${{ github.event.release.tag_name }}.zip
+         
+      - name: Upload archive to release
+        uses: JasonEtco/upload-to-release@master
+        with:
+          args: footnotes-${{ github.event.release.tag_name }}.zip application/zip
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+  release_to_svn:
+    name: Push the release to the WordPress Plugin Directory repo.
+    if: "!github.event.release.prerelease"
+    runs-on: ubuntu-latest
+    needs: create_archive
+
+    steps:
+      - name: Download Plugin artifact
+        uses: actions/download-artifact@v2
+        with:
+          name: footnotes-${{ github.event.release.tag_name }}
+
+      - name: Deploy release to Wordpress.org 
+        id: deploy
+        uses: 10up/action-wordpress-plugin-deploy@stable
+        env:
+          SVN_USERNAME: ${{ secrets.SVN_USERNAME }}
+          SVN_PASSWORD: ${{ secrets.SVN_PASSWORD }}
+          SLUG: footnotes/branches/svn-test
+          ASSETS_DIR: assets

_tools/release.sh

@@ -65,7 +65,7 @@ echo "- Checking versions..."
 
 STABLE_TAG="$(grep "Stable Tag:" src/readme.txt)"
 ROOT_HEADER_VERSION="$(grep " Version:" src/footnotes.php | grep -Po " Version: \d+\.\d+(\.\d+)?[a-z]?$")"
-JS_VERSION="$(grep "version :" src/js/wysiwyg-editor.js)"
+JS_VERSION="$(grep "version:" src/js/wysiwyg-editor.js)"
 
 # Step 3(b): Check that all version declarations exists
 

package.json

@@ -62,7 +62,7 @@
     "markdownlint-cli": "^0.27.1",
     "merge": "^2.1.1",
     "minify": "^7.0.1",
-    "node-sass": "^7.0.0",
+    "node-sass": "^5.0.0",
     "prettier": "^2.2.1",
     "stylelint": "^13.12.0",
     "stylelint-a11y": "^1.2.3",

renovate.json

@@ -1,6 +0,0 @@
-{
-  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
-  "extends": [
-    "config:base"
-  ]
-}

src/css/dev-common.css

@@ -607,12 +607,3 @@ Link color set to inherit, so referrers/numbers are not grayed out.
 .footnotes_logo_part2 {
 	color: #545f5a;
 }
-
-/** Fix for screen readers,
-@reporter @markhillyer
-@contributor @pewgeuges
-@link https://wordpress.org/support/topic/backlink-reference-number-font-weight/
-*/
-.footnote_plugin_index {
-	font-weight: normal;
-}

src/footnotes.php

@@ -113,7 +113,20 @@ require_once dirname( __FILE__ ) . '/includes.php';
 $l_str_plugin_file = 'footnotes/footnotes.php';
 add_filter( "plugin_action_links_{$l_str_plugin_file}", array( 'Footnotes_Hooks', 'get_plugin_links' ), 10, 2 );
 
-// Initialize the Plugin.
+/**
-$g_obj_mci_footnotes = new Footnotes();
+ * Initialises and runs the Plugin.
-// Run the Plugin.
+ *
-$g_obj_mci_footnotes->run();
+ * This takes place after the `plugins_loaded` hook, so that
+ * other Plugins may filter options.
+ *
+ * @since 2.7.4
+ */
+add_action(
+	'plugins_loaded',
+	function() {
+		// Initialize the Plugin.
+		$g_obj_mci_footnotes = new Footnotes();
+		// Run the Plugin.
+		$g_obj_mci_footnotes->run();
+	}
+);

src/wpml-config.xml

@@ -2,6 +2,7 @@
 	<admin-texts>
 		<key name="footnotes_storage">
 		    <key name="footnote_inputfield_references_label" />
+		    <key name="footnote_inputfield_readon_label" />
 		</key>
 	</admin-texts>
 </wpml-config>