Rumperuu/footnotes
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
655 commits 28 branches 78 tags 9 MiB
Commit graph

655 commits

This branch
This branch
All branches
Author SHA1 Message Date
Mark Cheret d809d00c23
Merge pull request #114 from markcheret/review-codebase 2021-04-19 13:32:37 +02:00
Ben Goldsworthy 57d5e40532
Merge branch 'main' into review-codebase 2021-04-19 12:27:24 +01:00
Ben Goldsworthy 2d4b778377 refactor: re-add Footnotes prefix to Hooks 2021-04-19 12:24:26 +01:00
Ben Goldsworthy 7adab1cd45 fix: correct ref container class name 2021-04-19 12:19:56 +01:00
Ben Goldsworthy 58683dd523 refactor: remove MCI prefixes 2021-04-19 12:16:05 +01:00
Ben Goldsworthy 2f809f4fe9 Revert "refactor: remove Hungarian notation and MCI prefixes" 
This reverts commit 1284544556.
 2021-04-19 12:15:17 +01:00
Mark Cheret f6a6852675
Merge pull request #125 from markcheret/dependabot/composer/marcocesarato/php-conventional-changelog-1.10.2 
build(deps-dev): bump marcocesarato/php-conventional-changelog from 1.10.1 to 1.10.2
 2021-04-19 11:44:21 +02:00
dependabot[bot] e9334cb733
build(deps-dev): bump marcocesarato/php-conventional-changelog 
Bumps [marcocesarato/php-conventional-changelog](https://github.com/marcocesarato/php-conventional-changelog) from 1.10.1 to 1.10.2.
- [Release notes](https://github.com/marcocesarato/php-conventional-changelog/releases)
- [Changelog](https://github.com/marcocesarato/php-conventional-changelog/blob/main/CHANGELOG.md)
- [Commits](https://github.com/marcocesarato/php-conventional-changelog/compare/v1.10.1...v1.10.2)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-04-19 09:33:05 +00:00
Ben Goldsworthy a754cd4fc2 docs: amend code of conduct 
<opinion>
Explicit enumeration makes sense in legal documents, but CoCs are
more aspirational so I don't think it makes sense in this context.
You will end up either having to constantly add new things to the
list, or declare that the list is non-exhaustive (in which there's
not much point in enumerating in the first place).

This is doubly true given the inherently woolly realm of appropriate
interpersonal interactions that a CoC is implemented to moderate.

Also, remember the KISS principle. Personally, I think this is the
pinnacle of CoC design: https://github.com/karlgroves/dontbeadick
However, I'm sure there is a slightly-more-professional middle
ground ;)
</opinion>
 2021-04-18 22:06:13 +01:00
Mark Cheret cf16c8a066
Merge pull request #123 from markcheret/add-code-of-conduct-1 
docs: add code of conduct
 2021-04-18 22:56:15 +02:00
Mark Cheret ae1b77730a
Merge pull request #122 from markcheret/markcheret-patch-1 
Update README.md
 2021-04-18 22:43:29 +02:00
Mark Cheret 6db94dafba
added sweet shields 2021-04-18 22:29:58 +02:00
Mark Cheret 5eb1b3040a
Create CODE_OF_CONDUCT.md 2021-04-18 22:02:30 +02:00
Mark Cheret 7ba0763c88
Update README.md 2021-04-18 21:58:11 +02:00
Mark Cheret 4dd3345685
docs: update readme and PHPDoc settings (#120) 
* update readme.txt

* Test

* Test

* docs: update documentation

* docs: add package tag

* docs: add PHPDoc config, alter Composer script

Co-authored-by: Rumperuu <me+footnotes@bengoldsworthy.net>
 2021-04-18 20:30:42 +01:00
Mark Cheret 226df694a2
Merge pull request #118 from markcheret/fix_103 
Fix paragraph separation
 2021-04-18 00:59:50 +02:00
Mark Cheret 5b02a3dd08 fixing docblock formatting 2021-04-18 00:26:44 +02:00
Mark Cheret fd9cb2aaa9
Update task.php 
update docblock
 2021-04-18 00:23:19 +02:00
Mark Cheret dc1ec81ad9
Update task.php 2021-04-18 00:19:23 +02:00
Mark Cheret 3d85de134e
Update task.php 
attribution
 2021-04-17 23:32:43 +02:00
Mark Cheret 242795a2b6
Update task.php 2021-04-17 23:28:05 +02:00
Laurent Zimmerli 36e92bac3d Fix paragraph split, thanks to @pewgeuges 2021-04-17 22:45:50 +02:00
Ben Goldsworthy c0672461b0 build: increase commitizen lengths 2021-04-17 00:00:21 +01:00
Ben Goldsworthy 1284544556 refactor: remove Hungarian notation and MCI prefixes 
I had to use some RegEx-fu for this. Specifically:

```bash
find ./{footnotes.php,includes.php,class/} -type f -name "*.php" -exec sed -i 's/\(p\|l\|a\)_\(str\|bool\|int\|obj\|flo\|arr\)_//g' {} \;
find ./{footnotes.php,includes.php,class/} -type f -name "*.php" -exec sed -i 's/MCI_Footnotes/Footnotes/g' {} \;
find ./{footnotes.php,includes.php,class/} -type f -name "*.php" -exec sed -i 's/C_\(INT\|STR\|FLO\)_//g' {} \;
```

This should have covered all the bases.

In my testing I encountered one error caused by these changes.
In the `add_select_box` function in `/class/dashboard/layout.php`,
there was a function parameter called `$p_arr_options` and a variable
called `$l_str_options`. Removing the Hungarian notation caused an
error as these two variables were both now called `$options`.

This has been fixed, and I like to think that that will have been
the only naming conflict, but I think it is more likely that there
maybe others. Further testing is required before I am happy calling
this release-ready.

Close #34, progress #36
 2021-04-16 23:55:05 +01:00
Ben Goldsworthy df7160fad8 build: tweak commands 2021-04-16 23:49:32 +01:00
Ben Goldsworthy 3af81c01b9 refactor: rename Hooks, update docblocks 2021-04-16 23:17:07 +01:00
Mark Cheret e06535852b
Merge pull request #106 from markcheret/relocate-plugin 
refactor: relocate Plugin settings
 2021-04-16 23:54:51 +02:00
Ben Goldsworthy 571b6bf74f fix: correct plugin settings link 2021-04-16 21:50:24 +01:00
Ben Goldsworthy b18e331684 refactor: rename colourpicker eclass 2021-04-16 21:50:02 +01:00
Mark Cheret 524c13c056
docs: remove features.txt (#110) 
has all been added in issues and discussions on GH
 2021-04-16 13:05:37 +01:00
Ben Goldsworthy d676f6d53f fix: fix pre-commit hook 2021-04-16 03:12:06 +01:00
Ben Goldsworthy f010c175ed refactor: move Plugin settings under general settings menu 2021-04-16 03:11:24 +01:00
Ben Goldsworthy 6b42f12716 refactor: delete now-unused files 2021-04-16 03:11:24 +01:00
Ben Goldsworthy ae3521d7d9 refactor: delete now-unused files 2021-04-16 03:11:24 +01:00
Ben Goldsworthy fd89026326 refactor: remove /class/layout dir (for now) 
This dir has been kicking around for a while as a holdover
from the big codebase standardisation. There's no point
keeping the dupe files for now, but I'll come back to this
again later.
 2021-04-16 03:11:24 +01:00
Mark Cheret b6513d9c4b
Merge pull request #105 from markcheret/php-compatibility-sniffs 
build: add PHPCompatibility sniffs
 2021-04-16 03:49:56 +02:00
Ben Goldsworthy 2d7f812560 build: add node_modules ignore 2021-04-16 01:43:25 +01:00
Ben Goldsworthy bdd99ac3bc fix: fix array dec 2021-04-16 01:34:08 +01:00
Ben Goldsworthy de4e53f941 build: add PHPCompat checks to pre-commit hook 2021-04-16 01:29:27 +01:00
Ben Goldsworthy 9926a42e8c style: lint code 2021-04-16 01:23:33 +01:00
Ben Goldsworthy 43a5de6cef build: add PHPCompatibility sniffs 2021-04-16 01:23:23 +01:00
Mark Cheret 06b8fb51c1
Merge pull request #101 from markcheret/hueman-theme-compat 
Hueman theme compat
 2021-04-16 02:09:08 +02:00
Ben Goldsworthy fcd350fe72 fix: minor tweaks 2021-04-16 01:01:55 +01:00
Mark Cheret f412774656
Update readme.txt 2021-04-16 00:54:28 +02:00
Mark Cheret 641d7d8963
Update footnotes.php 2021-04-16 00:52:30 +02:00
Mark Cheret cdbe2221eb
fix: replicate 2.7.1 CSS fix from SVN repo 
This was originally posted to the SVN repo., and has been replicated here because `git svn` is a write-off at this point.

Close #81 #99
 2021-04-15 22:56:39 +01:00
Mark Cheret 29dff8cfad closes #99 
closes #81
 2021-04-15 23:51:29 +02:00
Mark Cheret 6a32c828e1
Merge pull request #93 from markcheret/automated-linting 
build: add automated JS/CSS linting
 2021-04-15 23:10:30 +02:00
Mark Cheret ee7cd5356e
Merge branch 'main' into automated-linting 2021-04-15 23:09:20 +02:00
Mark Cheret e5f1ca92b1
Merge pull request #98 from markcheret/svn-sync 
sync with 2.7.0
 2021-04-15 23:07:10 +02:00