Commit graph

252 commits

Author SHA1 Message Date
Ben Goldsworthy 57d5e40532
Merge branch 'main' into review-codebase 2021-04-19 12:27:24 +01:00
Ben Goldsworthy 2d4b778377 refactor: re-add Footnotes prefix to Hooks 2021-04-19 12:24:26 +01:00
Ben Goldsworthy 7adab1cd45 fix: correct ref container class name 2021-04-19 12:19:56 +01:00
Ben Goldsworthy 58683dd523 refactor: remove MCI prefixes 2021-04-19 12:16:05 +01:00
Ben Goldsworthy 2f809f4fe9 Revert "refactor: remove Hungarian notation and MCI prefixes"
This reverts commit 1284544556.
2021-04-19 12:15:17 +01:00
Mark Cheret 4dd3345685
docs: update readme and PHPDoc settings (#120)
* update readme.txt

* Test

* Test

* docs: update documentation

* docs: add package tag

* docs: add PHPDoc config, alter Composer script

Co-authored-by: Rumperuu <me+footnotes@bengoldsworthy.net>
2021-04-18 20:30:42 +01:00
Mark Cheret 5b02a3dd08 fixing docblock formatting 2021-04-18 00:26:44 +02:00
Mark Cheret fd9cb2aaa9
Update task.php
update docblock
2021-04-18 00:23:19 +02:00
Mark Cheret dc1ec81ad9
Update task.php 2021-04-18 00:19:23 +02:00
Mark Cheret 3d85de134e
Update task.php
attribution
2021-04-17 23:32:43 +02:00
Mark Cheret 242795a2b6
Update task.php 2021-04-17 23:28:05 +02:00
Laurent Zimmerli 36e92bac3d Fix paragraph split, thanks to @pewgeuges 2021-04-17 22:45:50 +02:00
Ben Goldsworthy 1284544556 refactor: remove Hungarian notation and MCI prefixes
I had to use some RegEx-fu for this. Specifically:

```bash
find ./{footnotes.php,includes.php,class/} -type f -name "*.php" -exec sed -i 's/\(p\|l\|a\)_\(str\|bool\|int\|obj\|flo\|arr\)_//g' {} \;
find ./{footnotes.php,includes.php,class/} -type f -name "*.php" -exec sed -i 's/MCI_Footnotes/Footnotes/g' {} \;
find ./{footnotes.php,includes.php,class/} -type f -name "*.php" -exec sed -i 's/C_\(INT\|STR\|FLO\)_//g' {} \;
```

This should have covered all the bases.

In my testing I encountered one error caused by these changes.
In the `add_select_box` function in `/class/dashboard/layout.php`,
there was a function parameter called `$p_arr_options` and a variable
called `$l_str_options`. Removing the Hungarian notation caused an
error as these two variables were both now called `$options`.

This has been fixed, and I like to think that that will have been
the only naming conflict, but I think it is more likely that there
maybe others. Further testing is required before I am happy calling
this release-ready.

Close #34, progress #36
2021-04-16 23:55:05 +01:00
Ben Goldsworthy 3af81c01b9 refactor: rename Hooks, update docblocks 2021-04-16 23:17:07 +01:00
Ben Goldsworthy 571b6bf74f fix: correct plugin settings link 2021-04-16 21:50:24 +01:00
Ben Goldsworthy b18e331684 refactor: rename colourpicker eclass 2021-04-16 21:50:02 +01:00
Ben Goldsworthy f010c175ed refactor: move Plugin settings under general settings menu 2021-04-16 03:11:24 +01:00
Ben Goldsworthy 6b42f12716 refactor: delete now-unused files 2021-04-16 03:11:24 +01:00
Ben Goldsworthy fd89026326 refactor: remove /class/layout dir (for now)
This dir has been kicking around for a while as a holdover
from the big codebase standardisation. There's no point
keeping the dupe files for now, but I'll come back to this
again later.
2021-04-16 03:11:24 +01:00
Ben Goldsworthy 9926a42e8c style: lint code 2021-04-16 01:23:33 +01:00
Ben Goldsworthy a5356d8052 fix: other assorted fixes 2021-04-15 17:17:27 +01:00
Ben Goldsworthy b565a56a05 fix: replace apostrophes 1/2 2021-04-15 17:11:37 +01:00
Ben Goldsworthy 11c2af6f9c fix: correct constant name 2021-04-15 17:07:55 +01:00
Ben Goldsworthy d201d7e705 docs: remove timestamps 2021-04-15 17:07:04 +01:00
Ben Goldsworthy e867ea69d1 re-add /dashboard dir 2021-04-15 17:03:46 +01:00
Ben Goldsworthy 5b07c17356 Merge branch 'main' into svn-sync 2021-04-15 16:52:59 +01:00
Ben Goldsworthy ebb76dd1de Add temp file 2021-04-15 16:30:35 +01:00
Ben Goldsworthy 3a547af222 Rename dashboard/ to layout/. 2021-04-15 15:30:21 +00:00
Ben Goldsworthy 98d1255f57 Add temp file 2021-04-15 15:30:21 +00:00
Ben Goldsworthy 63a388ba29 Rename dashboard files 2021-04-15 15:30:21 +00:00
Ben Goldsworthy 27d3e6269e
chore: remove date info (#94)
* chore: remove @lastmodified tags

* chore: remove @date tags

* chore: remove timestamps

* chore: remove timestamps

* chore: minor formatting fixes
2021-04-15 05:09:23 +01:00
pewgeuges a02cdacb7f Release urgent feature 2.7.0 in response to request from user @grflukas.
https://wordpress.org/support/topic/multiple-reference-containers-in-single-post/
Bundled with two bugfixes.
https://github.com/markcheret/footnotes/issues/65
https://github.com/markcheret/footnotes/issues/71
Last release directly to SVN.
= 2.7.0 =
- Adding: Reference container: optionally per section by shortcode, thanks to @grflukas issue report.
- Bugfix: Excerpts: make excerpt handling backward compatible, thanks to @mfessler bug report.
- Bugfix: Dashboard: debug the 'Quick start guide' tab, thanks to @rumperuu bug report.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2515217 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-04-14 23:10:29 +00:00
Ben Goldsworthy eb34f30880 fix: correct relative filepaths 2021-04-14 22:52:56 +01:00
Ben Goldsworthy b824a44541 style: rename production flag variable
Renames the current production flag variable to be shorter,
non-Hungarian (presaging changes to come in #35) and not specifically
CSS_-related.

See #80
2021-04-14 22:47:44 +01:00
Ben Goldsworthy e76a4e0bb1 fix: add separate prod/dev cache-busters 2021-04-14 22:39:16 +01:00
Ben Goldsworthy 35d8b82008
chore: fix character misencodings (#78)
Various characters had been replaced by â€s.

Fix #77
2021-04-14 17:27:15 +01:00
pewgeuges dc225809ba - Release urgent bugfix v2.6.6
- Delete temporary tag 2.5.13.1
= 2.6.6 =
- Bugfix: Process: fix issue that caused some footnotes to not be processed, thanks to @docteurfitness @rkupadhya @offpeakdesign bug reports.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2513893 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-04-13 08:18:07 +00:00
Ben Goldsworthy 50115fb6c9
fix: fix bug that caused footnotes to not be processed (#75) 2021-04-12 21:10:23 +01:00
Ben Goldsworthy 0c75e12a99 fix: fix call to renamed function 2021-04-10 20:35:36 +01:00
Ben Goldsworthy 5d89b371dc fix: fix errors introduced in merge 2021-04-10 20:26:30 +01:00
Ben Goldsworthy 7ddac313bd Merge branch 'main' into svn-update 2021-04-10 20:02:10 +01:00
Ben Goldsworthy 2dc096f1f6 Rename dashboard/ to layout/. 2021-04-10 19:27:53 +01:00
Ben Goldsworthy 3d8719f653 Add temp file 2021-04-10 19:27:53 +01:00
Ben Goldsworthy 00556c1c84 Rename dashboard files 2021-04-10 19:27:53 +01:00
pewgeuges e49bb9e257 Release urgent bugfix v2.6.5 (Stable Tag 2.6.5).
Also add a temporary tag for another bugfix.
= 2.6.5 =
- Bugfix: Editor buttons: debug button by reverting name change in PHP file while JS file and HTML template remained unsynced, thanks to @gova bug report.
- Bugfix: Hooks: default-disable the_excerpt hook with respect to theme-specific excerpt handling, thanks to @mmallett bug reports.
= 2.5.13.1 =
- Bugfix: Backlinks: remove the 'event.stopPropagation()' call in scroll-down function.
Note: This bug is fixed in mainstream and is here only available temporarily while one known installation keeps using v2.5.13.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2507205 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-04-01 06:48:43 +00:00
pewgeuges 3aa88229e0 Bugfix 2.6.4 stable Tag 2.6.4.
= 2.6.4 =
- Bugfix: Process: remove trailing comma after last argument in multiline function calls for PHP < 7.3, thanks to @scroom bug report.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2506751 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-31 13:29:10 +00:00
pewgeuges ca3335e63c Release bugfix v2.6.3 Stable Tag 2.6.3.
Overdue bugfix, cannot be delayed.
Also the project has to demonstrate it’s still ready to **release** bugfixes.
Per SemVer the minor version number cannot be incremented for the below.
= 2.6.3 =
- Bugfix: Reference container: debug footnotes number text color in the table header cells required for accessibility, thanks to @spaceling bug report.
- Bugfix: Excerpts: debug the 'Yes' option by generating excerpts with footnotes on the basis of the posts, thanks to @nikelaos @martinneumannat bug reports.
- Bugfix: Reference container: debug span elements in backlinks by removing 'event.stopPropagation()' from jQuery scroll down function, thanks to @lolzim bug report.
- Update: Excerpts: set the default value of the debugged 'Footnotes in excerpts' setting to Yes.
- Update: Excerpts: enable the hook 'the_excerpt' by default to make the debugged 'Footnotes in excerpts' setting effective.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2506333 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-31 00:49:17 +00:00
pewgeuges 91fc02de88 2.6.3d0 with Stable Tag 2.6.0.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2505727 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-30 07:50:44 +00:00
pewgeuges a6a1a67b00 Unreleased urgent bugfix v2.6.2 with Stable Tag 2.6.0.
Needed for https://wordpress.org/support/topic/problem-with-footnotes-in-excerpts-of-the-blog-page/
= 2.6.2 =
- Bugfix: Excerpts: debug the 'No' option by generating excerpts from scratch without footnotes, thanks to @nikelaos @markcheret @martinneumannat bug reports.
- Bugfix: Tooltips: Continue reading: debug link for AMP compatibility mode.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2504730 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-28 12:41:33 +00:00
pewgeuges 258e3c6070 Unreleased bugfix v2.6.1 with Stable Tag 2.6.0.
Needed to share in a Forum topic where the problem came up incidentally.
Must also be shared in the Forum topic of the related bug report.
This also contains an escapement reversal (without known incidence on the plugin’s behavior).

= 2.6.1 =
- Bugfix: Tooltips: Styling: Font color: set to black for maximum contrast with respect to white default background, thanks to 4msc bug report.
- Bugfix: Tooltips: Styling: Background color: set default value back to white because empty doesn’t work out as expected.

= Branches =
Delete the staging branch.
Rationale:

- It is outdated an cannot be used for staging any more.
- It had been made improperly on its own instead of copying from trunk/.
- It is undue for the following reasons:
  - Staging release processes here is too dangerous.
  - Staging release processes here is too little effective.

Staging must not take place in this repository but in another SVN instance.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2504324 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-27 06:10:08 +00:00