Commit graph

475 commits

Author SHA1 Message Date
pewgeuges 7aa9d8803f Urgent bugfix development 2.5.11d5 with ST 2.5.10.
On top of 2.6.0d7.
Debugs Footnotes for all input field values with footnotes coming in from field label.
Preparing unreleased tagged v2.5.11 in response to Forum support request.
Accessibility fixes and AMP compat enhancements not fully debugged yet, draft only.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2499807 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-19 23:58:23 +00:00
pewgeuges 41676ea716 2.5.6d7 added 4 missing templates for AMP compat.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2498893 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-18 18:00:42 +00:00
pewgeuges ccb73fd421 Accessibility added, v2.6.0d6 (S.T. 2.5.10).
= Reference container semantics for assistive technology =
- Table header elements with row scope in the first column.
- Table caption invisible to sighted users but required for screen readers.
= Referrer accessibility =
- jQuery referrers are accessible but don’t show the tooltips on focus.
- AMP compatible tooltips show up on focus on navigatable referrers.
- Alternative tooltips now accessible on focus on now navigatable referrers.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2498648 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-18 10:53:57 +00:00
Ben Goldsworthy 0a34e96450
Add release helper script (#64)
This commit adds a release helper script, amongst other workflow improvements.

See `README.md` for instructions, and `_tools/release.sh` for the script itself.

This script:

1. sanity-checks the various version tags;
2. triggers a Plugin build;
3. flags the new version as pre-release;
4. tags the version in Git;
5. creates a local working copy of the SVN repo;
6. copies the new release to the local `trunk/` (whilst keeping the ‘Stable Tag’ field in `readme.txt` pointing to the previous stable version);
7. copies the commit message from the changelog in `readme.txt`; and
8. (if a flag is set) commits the changes to the remote `trunk/`.

Pushing out a new release must still be done manually, once `trunk/` is tested and working. To do so, check out a local copy of `trunk/` and:

1. update the ‘Stable Tag’ field in `trunk/readme.txt` to the new version;
2. update the ‘Version’ field in the comment header of `trunk/footnotes.php` to the new version;
3. remove the ‘p’ from the end of the ‘version’ tag in the `getInfo()` function at the bottom of `js/wsiwyg-editor.js`; 
4. copy a new tag for the release from `trunk/` (`svn cp trunk tags/<version number>`); and
5. commit your changes (`svn ci -m "Release version <version number>"`).

The WP Plugin Directory will automatically parse the ‘Stable Tag’ field in `trunk/readme.txt`, and inform users that a new version is available.

At various stages user input is required to validate information. This is not ready for automation with GitHub Actions, but is a useful step on the way — see [this piece](https://blog.danslimmon.com/2019/07/15/do-nothing-scripting-the-key-to-gradual-automation/) for more info.

Unless a `-c` flag is passed (e.g., by running `composer run release:commit`) no changes will take place on the remote SVN repo. If you want to test this out on a branch other than `main`, uncomment lines 31 & 52 of the script.

Version checking enforces the versioning rules stated [here](https://github.com/markcheret/footnotes/wiki/Versioning).

**NB: I have not tested the `-c` mode yet, as I wanted people will more familiarity with the SVN to have a look at it before I risked making any changes and blowing everything up.**

Co-authored-by: pewgeuges <73141620+pewgeuges@users.noreply.github.com>
2021-03-17 17:46:21 +00:00
pewgeuges 93d1c06373 Debugged development test and prerelease v2.6.0d5, Stable Tag 2.5.10.
Tooltip fade-in/fade-out now works in AMP and everything is functional,
except scroll animation because animated scrolling in AMP has only 3 positions.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2498089 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-17 15:51:49 +00:00
pewgeuges 12301035ab Correct style sheets, 2.6.0d4.
Bugs are now fixed except fade-in/fade-out.
Hopefully we’ll meet the looming deadline.
Thanks for testing and I’ll be reaching out to AMP-WP, in issue #48 to begin with.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2497475 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-17 02:35:34 +00:00
pewgeuges c8b3eba952 Bugs are now fixed except fade-in/fade-out, 2.6.0d3.
Hopefully we’ll meet the looming deadline.
Thanks for testing and I’ll be reaching out to AMP-WP, in issue #48 to begin with.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2497474 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-17 02:22:27 +00:00
pewgeuges f089e0446a Development 2.6.0d2 finished so far.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2497412 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-16 22:57:27 +00:00
pewgeuges c5a9af037a Development preview 2.6.0d1 with AMP compat at work.
Stable Tag is 2.5.10. v2.6.0d0 does already exist on SVN (2456650 2021-01-14).
Tooltip timing settings are not yet usable in AMP mode.
Tooltip transitions don’t work now, only delays, need to debug.
It’s late and we have a deadline, so this is committed as a preview.
Thanks for looking into it.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2497297 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-16 19:41:08 +00:00
pewgeuges 7b7b8547b1 Traceability update to move constant docblocks class/settings.php.
Delta version 2.5.11d4; Stable Tag: 2.5.10.
No changes but sorting by version number.
This makes sure that other changes coming after will be traceable in SVN.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2496283 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-15 20:03:16 +00:00
pewgeuges 3f78157481 Traceability update for trunk/ with Stable Tag 2.5.10.
Delta version 2.5.11d3.
Before sorting constants in settings.php by version number (@since tag).
The next commit is dedicated to moving constants and their docblocks in settings.php.
This replaces most of the list items in the file level docblock.
Moving blocks of code breaks traceability of changes, so it’s usually avoided.
WordPress plugins are supposed to maintain traceability in the SVN repo, which implies keeping changesets meaningful.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2496275 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-15 19:37:41 +00:00
Mark Cheret 0a83796cdc
Update author URIs (#63)
* Update author URIs from `cheret.de` to `cheret.org`.

* Update missed version number in `wysiwyg.js` from 2.1.6 to 2.5.10.

Co-authored-by: pewgeuges <73141620+pewgeuges@users.noreply.github.com>
2021-03-15 07:11:12 +00:00
pewgeuges 67993df90f Sync trunk/ with staging branch. **Stable Tag 2.5.10**
branches/staging/ is most up-to-date: 2.5.11d2.
Per WordPress guideline, “trunk/ should contain the latest version of your code, even if that version is a beta.”
See https://developer.wordpress.org/plugins/wordpress-org/how-to-use-subversion/#use-the-trunk-folder-for-code
= Moved files =
Two documentation files are moved from development/ to the root folder:
- customized-template-stack.txt
- customized-documentation-schema.txt
= Deleted files and folders =
Part of the tooling and the duplicate license were mistakenly included and are now removed from distribution:
- development/csscat.sh
- contrib/pre-commit
- composer.json
- composer.lock
- LICENSE
The comments shall be updated accordingly.
development/csscat.sh is now _tools/build-stylesheets.sh, available in Footnotes’ GitHub repo.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2495062 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-13 22:21:26 +00:00
Ben Goldsworthy e8d6dbe13d
Automatically generate new releases (#59)
* Adapt after the 2.5.9d1 accident.

* Corrections to changelog.

* Also added @‌revision and @‌timestamp PHPDOC tags
@‌revision and @‌timestamp used for SVN refs.

Full enumeration of added custom PHPDOC tags:
@‌accountable, @‌bib, @‌biblio, @‌callback, @‌commit, @‌committer, @‌contributor, @‌courtesy, @‌date, @‌datetime, @‌lastmodified, @‌modified, @‌publisher, @‌reporter, @‌revision, @‌timestamp, @‌user.Some tags like @‌reporter and @‌contributor are more used than others.

* Readme header upgrade.

* Create deploy-to-wordpress.org.yml

* Add distignore

* Comment out `build` command, replace npm with composer

* Remove placeholder comments

* Add build commands

* Fix typo

* Fix version number bug

* Make zip without top-level directory

* Append tag name to plugin zip

* Clean up a bit

* Rename workflow config

* Fix upload paths

* Append tag name to artifact

* Fix paths

* Revert path fix

* Try again

* Add wplm-config.xml to buildfiles

* Fix indentation

* Rename development/csscat.sh to css/csscat.sh

* Rename development/customized-documentation-schema.txt to customized-documentation-schema.txt

* Rename development/customized-template-stack.txt to customized-template-stack.txt

* Version number related fixes before pull request.

* Move csscat script to tools dir

* Rename csscat

* Refactor script

* Update customized-documentation-schema.txt

* Replace empty lines in help output

* Escape empty lines.

* Delete 3 items from `.distignore`
As mentioned, CONTRIBUTING.md and README.md should be included in distributions.

- As an invitation to the Community.
- As a tangible proof of goodwill after the 2.5.9d1 accident.

Also SECURITY.md so Footnotes users see that we’re concerned, and
can reach out without transiting via GitHub.

* Include CONTRIBUTING.md README.md SECURITY.md

* Update sync w/ 5.7 tested.

* Update

* Update composerfiles

Co-authored-by: pewgeuges <73141620+pewgeuges@users.noreply.github.com>
2021-03-12 17:53:49 +00:00
Ben Goldsworthy 5c9e611837
Update supported WP version to 5.7 (#62)
* Update supported WP version to 5.7

* Update package version

* Add Package Version in MAIN.php

* Change version number labels.

* Obfuscate 'Version' string in label.
The way these headers are parsed, best is to make sure that
the string 'Version' doesn’t occur in another field label.

Co-authored-by: pewgeuges <73141620+pewgeuges@users.noreply.github.com>
2021-03-12 09:48:47 +00:00
pewgeuges cc97c2eb71 Tested-up-to value updated per WordPress instructions and Team agreement.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2493329 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-11 14:37:00 +00:00
Ben Goldsworthy ebdb68969b
Merge pull request #61 from markcheret/fixcomments
Version number related fixes for now.
2021-03-11 09:18:14 +00:00
pewgeuges b6f6ff76f3 Version number related fixes before pull request. 2021-03-11 06:26:34 +01:00
pewgeuges 0e6c5a8f87 Readme header upgrade. 2021-03-08 10:10:32 +01:00
pewgeuges 6ff77dc74d Also added @‌revision and @‌timestamp PHPDOC tags
@‌revision and @‌timestamp used for SVN refs.

Full enumeration of added custom PHPDOC tags:
@‌accountable, @‌bib, @‌biblio, @‌callback, @‌commit, @‌committer, @‌contributor, @‌courtesy, @‌date, @‌datetime, @‌lastmodified, @‌modified, @‌publisher, @‌reporter, @‌revision, @‌timestamp, @‌user.Some tags like @‌reporter and @‌contributor are more used than others.
2021-03-05 08:58:48 +01:00
pewgeuges f63dfde076 Corrections to changelog. 2021-03-05 08:44:15 +01:00
pewgeuges 46fc9a7c5f Adapt after the 2.5.9d1 accident. 2021-03-05 04:30:50 +01:00
pewgeuges 6b9e602d07
Sync filenames with SVN repo (#57)
Returns to the original file names for the `class/dashboard/` directory (for now at least)
2021-03-04 07:46:19 +00:00
pewgeuges daf0a8612f WordPress Coding Standards compliance update. Stable Tag 2.5.10. Package version: 2.5.11d0.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2486043 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-03 18:58:03 +00:00
pewgeuges dfcbdc6adc Undo last two commits affecting trunk/ but not the Stable Tag.
= Stable Tag value =
2.5.10 (unchanged)
= Commits undone =
- 2484038 (2021-03-02 05:29:18 +0000 (Tue, 02 Mar 2021)) committer: pewgeuges
-2484015 (2021-03-02 04:22:20 +0000 (Tue, 02 Mar 2021)) committer: pewgeuges
= Rationale =
By renaming a folder (and 3 out of 4 included files), the WordPress Coding Standards compliance upgrade (see changeset 2484015) has broken the traceability of the changes made to the following files:
- footnotes/trunk/class/dashboard/init.php
- footnotes/trunk/class/dashboard/layout.php
- footnotes/trunk/class/dashboard/subpage-diagnostics.php
- footnotes/trunk/class/dashboard/subpage-main.php

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2485882 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-03 15:15:55 +00:00
Ben Goldsworthy ef6dd57310
Update version number to 2.5.10 (#54)
* Update version number to 2.5.10 (current stable tag)

See [here](https://github.com/markcheret/footnotes/pull/54#discussion_r585895136) for discussion; **stable tags only to be used until releases are automated**
2021-03-02 21:47:09 +00:00
pewgeuges 1fe04f9ac6 Sync metadata in trunk/ with current release 2.5.10 (no d version).
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2484038 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-02 05:29:18 +00:00
pewgeuges c63d3f629f Update to standardised codebase as on GitHub origin/main/, 2.5.8. Stable Tag value set to 2.5.10 since it’s parsed to determine current release.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2484015 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-02 04:22:20 +00:00
pewgeuges caf3e1136c Convert EOL from CRLF to LF.
to make footnotes/trunk/ diffable against the standardised codebase on GitHub markcheret/footnotes/.
Stable Tag remains 2.5.10.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483994 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-02 03:09:34 +00:00
pewgeuges ba9d9bc535 Revert to 2.5.8 in the new Stable Tag 2.5.10.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483464 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 11:09:29 +00:00
Ben Goldsworthy 8a859b61f7 Re-standardise codebase to WP Coding Standards (this time without the line ending changes)
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483354 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 07:57:12 +00:00
Ben Goldsworthy 05d316ae15 Revert standardise codebase to WP Coding Standards
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483350 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 07:54:03 +00:00
Ben Goldsworthy 6a5fcedac3 Standardise codebase to WP Coding Standards
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483336 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 07:37:59 +00:00
Ben Goldsworthy 2e0b2f8d98
Merge pull request #50 from markcheret/wp-coding-standard--fresh
Update code to comply with WP Coding Standards (*fourth* time's the charm!)
2021-02-28 20:03:45 +00:00
Ben Goldsworthy f129f3a392 Renormalise line endings 2021-02-28 14:13:07 +00:00
pewgeuges 526cde8830 Release urgent bugfix v2.5.8 in response to Forum and per instructions/agreement.
= 2.5.8 =
- Bugfix: Layout: support right-to-left writing direction by replacing remaining CSS values left with start, thanks to @arahmanshaalan bug report.\n- Bugfix: Layout: support right-to-left writing direction by enabling mirrored paddings on HTML dir="rtl" pages, thanks to @arahmanshaalan bug report.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483011 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-28 13:34:24 +00:00
pewgeuges ef8050477b Backport upcoming bugfix release 2.5.8
Will be released in response to Forum and as agreed.
= 2.5.8 =
- Bugfix: Layout: support right-to-left writing direction by replacing remaining CSS values 'left' with 'start', thanks to @arahmanshaalan bug report.
- Bugfix: Layout: support right-to-left writing direction by enabling mirrored paddings on HTML dir=rtl pages, thanks to @arahmanshaalan bug report.
2021-02-28 14:24:57 +01:00
pewgeuges 8a01584196 Restore lost corrections 2021-02-28 00:53:50 +01:00
Ben Goldsworthy 25c3f2f12e Replace output escape and input sanitization functions with linter supression messages 2021-02-27 08:49:08 +00:00
Ben Goldsworthy 74ac6f1cad Rebase to 2.5.7 2021-02-27 08:34:58 +00:00
Ben Goldsworthy cbefa2e9d7 Add authorsfile to gitignore 2021-02-27 08:14:09 +00:00
Ben Goldsworthy f5b2e1f30f Rebase to 2.5.7 2021-02-27 08:12:17 +00:00
Ben Goldsworthy 9c88d218a8 Revert "Update code to comply with WP Coding Standards (#38)"
This reverts commit 02c6c1c362.
2021-02-27 08:09:08 +00:00
Ben Goldsworthy dac7ffe3a6 Update code to comply with WP Coding Standards (#38)
Co-authored-by: @pewgeuges <pewgeuges@gmail.com>
2021-02-27 08:06:32 +00:00
Ben Goldsworthy 8d0ebdb859 Append line endings 2021-02-27 08:03:04 +00:00
Ben Goldsworthy cf3616f65c Fix indentation 2021-02-27 07:55:43 +00:00
Ben Goldsworthy 04d1bb390b Alter formatting, add contribution information 2021-02-27 07:55:43 +00:00
Mark Cheret 5c1884f059 Update README.md 2021-02-27 07:55:26 +00:00
Mark Cheret 75f4287aa3 Update CONTRIBUTING.md 2021-02-27 07:54:34 +00:00
Mark Cheret 6297965716 Update README.md
moved image due to repo change
2021-02-27 07:54:34 +00:00