Commit graph

138 commits

Author SHA1 Message Date
Mark Cheret cdbe2221eb
fix: replicate 2.7.1 CSS fix from SVN repo
This was originally posted to the SVN repo., and has been replicated here because `git svn` is a write-off at this point.

Close #81 #99
2021-04-15 22:56:39 +01:00
Ben Goldsworthy 72d3078fa3
Merge branch 'main' into automated-linting 2021-04-15 15:07:27 +01:00
Ben Goldsworthy 27d3e6269e
chore: remove date info (#94)
* chore: remove @lastmodified tags

* chore: remove @date tags

* chore: remove timestamps

* chore: remove timestamps

* chore: minor formatting fixes
2021-04-15 05:09:23 +01:00
Ben Goldsworthy d52de71726 chore: lint CSS files
The linter throws loads of errors - this commit only makes those
fixes that Stylelint can make automatically.
2021-04-15 03:12:37 +01:00
Ben Goldsworthy 7ddac313bd Merge branch 'main' into svn-update 2021-04-10 20:02:10 +01:00
pewgeuges 91fc02de88 2.6.3d0 with Stable Tag 2.6.0.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2505727 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-30 07:50:44 +00:00
pewgeuges 258e3c6070 Unreleased bugfix v2.6.1 with Stable Tag 2.6.0.
Needed to share in a Forum topic where the problem came up incidentally.
Must also be shared in the Forum topic of the related bug report.
This also contains an escapement reversal (without known incidence on the plugin’s behavior).

= 2.6.1 =
- Bugfix: Tooltips: Styling: Font color: set to black for maximum contrast with respect to white default background, thanks to 4msc bug report.
- Bugfix: Tooltips: Styling: Background color: set default value back to white because empty doesn’t work out as expected.

= Branches =
Delete the staging branch.
Rationale:

- It is outdated an cannot be used for staging any more.
- It had been made improperly on its own instead of copying from trunk/.
- It is undue for the following reasons:
  - Staging release processes here is too dangerous.
  - Staging release processes here is too little effective.

Staging must not take place in this repository but in another SVN instance.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2504324 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-27 06:10:08 +00:00
pewgeuges 123db83af4 Unreleased bugfix v2.5.14 with Stable Tag 2.5.10.
Urgent response to https://wordpress.org/support/topic/footnotes-content-number-not-sequential/
= 2.5.14 =
- Bugfix: Footnote delimiter short codes: fix numbering bug by cross-editor HTML escapement schema harmonization, thanks to @patrick_here @alifarahani8000 @gova bug reports.
- Update: Dashboard: General settings: Footnote start and end short codes: delete comment on pointy brackets.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2502988 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-25 03:07:17 +00:00
pewgeuges 0dc4c08dd8 Unreleased bugfix v2.5.13 with Stable Tag 2.5.10.
= 2.5.13 =
- Bugfix: Dashboard: Backlink symbol: debug select box by reverting identity check to equality check, thanks to @lolzim bug report.
- Bugfix: Footnote delimiter short codes: debug closing pointy brackets in the Block Editor by accounting for unbalanced HTML escapement.
- Update: Dashboard: General settings: Footnote start and end short codes: update information about short codes using pointy brackets.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2502882 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-24 21:19:07 +00:00
pewgeuges 9e8e28412e Urgent unreleased bugfix version 2.5.12 with Stable Tag 2.5.10.
= 2.5.12 =
- Update: Scrolling: CSS-based smooth scroll behavior (optional), thanks to @paulgpetty and @bogosavljev issue reports.
- Bugfix: Backlinks: reflect scroll functions down/up differentiation across the template set, thanks to @bogosavljev bug report.
- Bugfix: Referrers: Hard links: enforce scroll offset with '!important' property for surroundings specifying otherwise, thanks to @bogosavljev bug report.
- Bugfix: Forms: prevent inadvertently toggling input elements with footnotes in their label, by optionally moving footnotes after the end of the label.
- Bugfix: Forms: prevent inadvertently toggling input elements with footnotes in their label, by optionally disconnecting those labels.
- Bugfix: Scroll offset: correct syntax error in the main style sheet.
- Bugfix: Reference container: correct new syntax errors in the 8 reference container row templates.
- Bugfix: Reference container: correct a new typo in the JavaScript reference container template.
- Update: Dashboard: General settings: split a dedicated 'URL fragment ID configuration' metabox off the 'Scrolling behavior' metabox.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2501451 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-23 04:02:07 +00:00
pewgeuges ce42420149 Stable Tag remains 2.5.10 as this urgent bugfix v2.5.11 is tagged while 2.6.0 isn’t ready yet.
= 2.5.11 =
- Bugfix: Forms: remove footnotes from input field values, thanks to @bogosavljev bug report.
- Bugfix: Reference container: apply web semantics to improve readability for assistive technologies, thanks to @derivationfr issue report and code contribution.
- Bugfix: Tooltips: Styling: Background color: empty default value to adopt theme background, thanks to 4msc bug report.
- Bugfix: Dashboard: debug text input fields by disabling quotation mark escapement, thanks to @rumperuu code contribution in the standards compliance overhaul.
- Update: Documentation: Readme.txt: comment line below the 'Stable Tag' field to warn that this field is (unintuitively) parsed for release configuration.
- Update: Documentation: Readme.txt: informative 'Version' field in sync with 'Version' in 'footnotes.php' for bugfix versions available ahead of the Stable Tag.
- Update: Documentation: Readme.txt: informative 'Package Version' field in sync with the 'Package V.' field added in the 'footnotes.php' file header.
- Update: Codebase: make PHP code comply to WordPress PHP Coding Standards requirements, thanks to @rumperuu code contribution and refactoring.
- Bugfix: Forms: mitigate the adverse effect of clicking footnote referrers in labels of input elements by an optional, configurable scroll down delay.
- Bugfix: Scroll durations: mitigate the downside of delayed scrolling down by optionally enabling asymmetric scroll durations (e.g. fast down, slower up).
- Update: Scroll delays: add a setting to configure also a scroll up delay for completeness.
- Bugfix: Tooltips: Styling: protect padding against removal in surroundings with explicit zero padding.
- Bugfix: Tooltips: Display: CSS transitions: fix syntax error.
- Update: Documentation: help and support for contributors by the means of Contributing Guidelines in 'CONTRIBUTING.md', thanks to @rumperuu code contribution.
- Update: Documentation: additional readme in markdown format 'README.md' for use with the code repository on GitHub, thanks to @rumperuu code contribution.
- Update: Documentation: move 'customized-template-stack.txt' and 'customized-documentation-schema.txt' from the 'development/' folder to root.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2500516 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-21 19:19:04 +00:00
pewgeuges 27b33e7a6f 2.5.11d6 debugging tooltips transitions and padding.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2499895 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-20 03:22:07 +00:00
pewgeuges 7aa9d8803f Urgent bugfix development 2.5.11d5 with ST 2.5.10.
On top of 2.6.0d7.
Debugs Footnotes for all input field values with footnotes coming in from field label.
Preparing unreleased tagged v2.5.11 in response to Forum support request.
Accessibility fixes and AMP compat enhancements not fully debugged yet, draft only.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2499807 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-19 23:58:23 +00:00
pewgeuges ccb73fd421 Accessibility added, v2.6.0d6 (S.T. 2.5.10).
= Reference container semantics for assistive technology =
- Table header elements with row scope in the first column.
- Table caption invisible to sighted users but required for screen readers.
= Referrer accessibility =
- jQuery referrers are accessible but don’t show the tooltips on focus.
- AMP compatible tooltips show up on focus on navigatable referrers.
- Alternative tooltips now accessible on focus on now navigatable referrers.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2498648 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-18 10:53:57 +00:00
Ben Goldsworthy 0a34e96450
Add release helper script (#64)
This commit adds a release helper script, amongst other workflow improvements.

See `README.md` for instructions, and `_tools/release.sh` for the script itself.

This script:

1. sanity-checks the various version tags;
2. triggers a Plugin build;
3. flags the new version as pre-release;
4. tags the version in Git;
5. creates a local working copy of the SVN repo;
6. copies the new release to the local `trunk/` (whilst keeping the ‘Stable Tag’ field in `readme.txt` pointing to the previous stable version);
7. copies the commit message from the changelog in `readme.txt`; and
8. (if a flag is set) commits the changes to the remote `trunk/`.

Pushing out a new release must still be done manually, once `trunk/` is tested and working. To do so, check out a local copy of `trunk/` and:

1. update the ‘Stable Tag’ field in `trunk/readme.txt` to the new version;
2. update the ‘Version’ field in the comment header of `trunk/footnotes.php` to the new version;
3. remove the ‘p’ from the end of the ‘version’ tag in the `getInfo()` function at the bottom of `js/wsiwyg-editor.js`; 
4. copy a new tag for the release from `trunk/` (`svn cp trunk tags/<version number>`); and
5. commit your changes (`svn ci -m "Release version <version number>"`).

The WP Plugin Directory will automatically parse the ‘Stable Tag’ field in `trunk/readme.txt`, and inform users that a new version is available.

At various stages user input is required to validate information. This is not ready for automation with GitHub Actions, but is a useful step on the way — see [this piece](https://blog.danslimmon.com/2019/07/15/do-nothing-scripting-the-key-to-gradual-automation/) for more info.

Unless a `-c` flag is passed (e.g., by running `composer run release:commit`) no changes will take place on the remote SVN repo. If you want to test this out on a branch other than `main`, uncomment lines 31 & 52 of the script.

Version checking enforces the versioning rules stated [here](https://github.com/markcheret/footnotes/wiki/Versioning).

**NB: I have not tested the `-c` mode yet, as I wanted people will more familiarity with the SVN to have a look at it before I risked making any changes and blowing everything up.**

Co-authored-by: pewgeuges <73141620+pewgeuges@users.noreply.github.com>
2021-03-17 17:46:21 +00:00
pewgeuges 93d1c06373 Debugged development test and prerelease v2.6.0d5, Stable Tag 2.5.10.
Tooltip fade-in/fade-out now works in AMP and everything is functional,
except scroll animation because animated scrolling in AMP has only 3 positions.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2498089 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-17 15:51:49 +00:00
pewgeuges 12301035ab Correct style sheets, 2.6.0d4.
Bugs are now fixed except fade-in/fade-out.
Hopefully we’ll meet the looming deadline.
Thanks for testing and I’ll be reaching out to AMP-WP, in issue #48 to begin with.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2497475 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-17 02:35:34 +00:00
pewgeuges c8b3eba952 Bugs are now fixed except fade-in/fade-out, 2.6.0d3.
Hopefully we’ll meet the looming deadline.
Thanks for testing and I’ll be reaching out to AMP-WP, in issue #48 to begin with.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2497474 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-17 02:22:27 +00:00
pewgeuges f089e0446a Development 2.6.0d2 finished so far.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2497412 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-16 22:57:27 +00:00
pewgeuges c5a9af037a Development preview 2.6.0d1 with AMP compat at work.
Stable Tag is 2.5.10. v2.6.0d0 does already exist on SVN (2456650 2021-01-14).
Tooltip timing settings are not yet usable in AMP mode.
Tooltip transitions don’t work now, only delays, need to debug.
It’s late and we have a deadline, so this is committed as a preview.
Thanks for looking into it.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2497297 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-16 19:41:08 +00:00
pewgeuges caf3e1136c Convert EOL from CRLF to LF.
to make footnotes/trunk/ diffable against the standardised codebase on GitHub markcheret/footnotes/.
Stable Tag remains 2.5.10.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483994 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-02 03:09:34 +00:00
pewgeuges ba9d9bc535 Revert to 2.5.8 in the new Stable Tag 2.5.10.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483464 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 11:09:29 +00:00
Ben Goldsworthy 8a859b61f7 Re-standardise codebase to WP Coding Standards (this time without the line ending changes)
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483354 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 07:57:12 +00:00
Ben Goldsworthy 05d316ae15 Revert standardise codebase to WP Coding Standards
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483350 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 07:54:03 +00:00
Ben Goldsworthy 6a5fcedac3 Standardise codebase to WP Coding Standards
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483336 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 07:37:59 +00:00
Ben Goldsworthy f129f3a392 Renormalise line endings 2021-02-28 14:13:07 +00:00
pewgeuges 526cde8830 Release urgent bugfix v2.5.8 in response to Forum and per instructions/agreement.
= 2.5.8 =
- Bugfix: Layout: support right-to-left writing direction by replacing remaining CSS values left with start, thanks to @arahmanshaalan bug report.\n- Bugfix: Layout: support right-to-left writing direction by enabling mirrored paddings on HTML dir="rtl" pages, thanks to @arahmanshaalan bug report.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483011 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-28 13:34:24 +00:00
pewgeuges ef8050477b Backport upcoming bugfix release 2.5.8
Will be released in response to Forum and as agreed.
= 2.5.8 =
- Bugfix: Layout: support right-to-left writing direction by replacing remaining CSS values 'left' with 'start', thanks to @arahmanshaalan bug report.
- Bugfix: Layout: support right-to-left writing direction by enabling mirrored paddings on HTML dir=rtl pages, thanks to @arahmanshaalan bug report.
2021-02-28 14:24:57 +01:00
Ben Goldsworthy 9ee72568ef Append line endings 2021-02-23 16:00:59 +00:00
pewgeuges 67c1f443ad development update 2.5.6d2 to prepare the newly promised bugfix release adding a reference container template not using jQuery, plain JS instead.\nThe following is the changelog as drafted for this release: \n= 2.5.6 =\n- Bugfix: Reference container: optional alternative expanding and collapsing without jQuery for use with hard links, thanks to @hopper87it issue report.\n- Update: Documentation: slightly revise / update the plugin’s welcome page on WordPress.org.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2477898 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-19 19:42:45 +00:00
pewgeuges 7f5499723b traceability update 2.5.6d1 revert space indent to tab.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2477300 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-18 19:56:44 +00:00
pewgeuges f8a87d5928 dev version implementing @lolzim’s bugfix 2.5.5d2
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2476267 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-17 10:58:28 +00:00
pewgeuges d9e23677b0 traceability update 2.5.5d1
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2476187 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-17 09:33:04 +00:00
pewgeuges 3a341d36b2 development update 2.5.5d0 to be shared on the forum
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2475227 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-16 02:23:40 +00:00
pewgeuges cc52be66fa urgent bugfix 2.5.4 added missing CSS fix, ready for release?
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2474039 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-12 23:15:02 +00:00
pewgeuges e328969abf update for urgent bugfix release 2.5.4 - preview
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2473889 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-12 17:09:45 +00:00
pewgeuges eaaad12e9b prepare urgent bugfix release 2.5.4 - this: 2.5.4d7
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2473867 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-12 16:22:45 +00:00
pewgeuges b009311766 prepare urgent bugfix release 2.5.4 - this: 2.5.4d6
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2473635 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-12 10:18:31 +00:00
pewgeuges b9476b682e traceability update 2.5.4d5
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2472973 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-11 10:34:35 +00:00
pewgeuges 6706ba811e development version for urgent bugfix test in response to Forum (2.5.4d1)
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2466893 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-02 04:40:41 +00:00
pewgeuges b34c0c12ab update with last changes (2.5.4d0)
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2463046 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-26 17:01:53 +00:00
pewgeuges 12a53754ab update for urgent bugfix upcoming 2.5.3
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2461253 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-23 00:25:35 +00:00
pewgeuges 49bb66b8bd urgent release 2.5.2
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2459302 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-19 23:45:34 +00:00
pewgeuges 22d6367a65 corrections for urgent bugfix, this: 2.5.1d2
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2458560 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-18 21:31:11 +00:00
pewgeuges f83fb80ab0 corrections for urgent bugfix, this: 2.5.1d1
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2458521 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-18 20:35:16 +00:00
pewgeuges c3c0515308 update for urgent bugfix, this: 2.5.1d0
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2458511 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-18 20:09:43 +00:00
pewgeuges 1c7debbaf5 update with last changes (2.6.0d0)
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2456650 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-14 22:56:43 +00:00
pewgeuges 354b5439f0 update trunk/ in vue of urgent bugfix plus feature release 2.5.0
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2452163 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-07 21:21:29 +00:00
pewgeuges 82cb6d5268 development 2.4.0d0 needed for support
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2449533 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-03 20:03:51 +00:00
pewgeuges 919e76bdef development 2.3.1d0 for forum
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2448740 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-01 05:52:49 +00:00