Commit graph

96 commits

Author SHA1 Message Date
1284544556 refactor: remove Hungarian notation and MCI prefixes
I had to use some RegEx-fu for this. Specifically:

```bash
find ./{footnotes.php,includes.php,class/} -type f -name "*.php" -exec sed -i 's/\(p\|l\|a\)_\(str\|bool\|int\|obj\|flo\|arr\)_//g' {} \;
find ./{footnotes.php,includes.php,class/} -type f -name "*.php" -exec sed -i 's/MCI_Footnotes/Footnotes/g' {} \;
find ./{footnotes.php,includes.php,class/} -type f -name "*.php" -exec sed -i 's/C_\(INT\|STR\|FLO\)_//g' {} \;
```

This should have covered all the bases.

In my testing I encountered one error caused by these changes.
In the `add_select_box` function in `/class/dashboard/layout.php`,
there was a function parameter called `$p_arr_options` and a variable
called `$l_str_options`. Removing the Hungarian notation caused an
error as these two variables were both now called `$options`.

This has been fixed, and I like to think that that will have been
the only naming conflict, but I think it is more likely that there
maybe others. Further testing is required before I am happy calling
this release-ready.

Close #34, progress #36
2021-04-16 23:55:05 +01:00
9926a42e8c style: lint code 2021-04-16 01:23:33 +01:00
5b07c17356 Merge branch 'main' into svn-sync 2021-04-15 16:52:59 +01:00
27d3e6269e
chore: remove date info (#94)
* chore: remove @lastmodified tags

* chore: remove @date tags

* chore: remove timestamps

* chore: remove timestamps

* chore: minor formatting fixes
2021-04-15 05:09:23 +01:00
pewgeuges
a02cdacb7f Release urgent feature 2.7.0 in response to request from user @grflukas.
https://wordpress.org/support/topic/multiple-reference-containers-in-single-post/
Bundled with two bugfixes.
https://github.com/markcheret/footnotes/issues/65
https://github.com/markcheret/footnotes/issues/71
Last release directly to SVN.
= 2.7.0 =
- Adding: Reference container: optionally per section by shortcode, thanks to @grflukas issue report.
- Bugfix: Excerpts: make excerpt handling backward compatible, thanks to @mfessler bug report.
- Bugfix: Dashboard: debug the 'Quick start guide' tab, thanks to @rumperuu bug report.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2515217 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-04-14 23:10:29 +00:00
7ddac313bd Merge branch 'main' into svn-update 2021-04-10 20:02:10 +01:00
pewgeuges
e49bb9e257 Release urgent bugfix v2.6.5 (Stable Tag 2.6.5).
Also add a temporary tag for another bugfix.
= 2.6.5 =
- Bugfix: Editor buttons: debug button by reverting name change in PHP file while JS file and HTML template remained unsynced, thanks to @gova bug report.
- Bugfix: Hooks: default-disable the_excerpt hook with respect to theme-specific excerpt handling, thanks to @mmallett bug reports.
= 2.5.13.1 =
- Bugfix: Backlinks: remove the 'event.stopPropagation()' call in scroll-down function.
Note: This bug is fixed in mainstream and is here only available temporarily while one known installation keeps using v2.5.13.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2507205 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-04-01 06:48:43 +00:00
pewgeuges
ca3335e63c Release bugfix v2.6.3 Stable Tag 2.6.3.
Overdue bugfix, cannot be delayed.
Also the project has to demonstrate it’s still ready to **release** bugfixes.
Per SemVer the minor version number cannot be incremented for the below.
= 2.6.3 =
- Bugfix: Reference container: debug footnotes number text color in the table header cells required for accessibility, thanks to @spaceling bug report.
- Bugfix: Excerpts: debug the 'Yes' option by generating excerpts with footnotes on the basis of the posts, thanks to @nikelaos @martinneumannat bug reports.
- Bugfix: Reference container: debug span elements in backlinks by removing 'event.stopPropagation()' from jQuery scroll down function, thanks to @lolzim bug report.
- Update: Excerpts: set the default value of the debugged 'Footnotes in excerpts' setting to Yes.
- Update: Excerpts: enable the hook 'the_excerpt' by default to make the debugged 'Footnotes in excerpts' setting effective.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2506333 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-31 00:49:17 +00:00
pewgeuges
258e3c6070 Unreleased bugfix v2.6.1 with Stable Tag 2.6.0.
Needed to share in a Forum topic where the problem came up incidentally.
Must also be shared in the Forum topic of the related bug report.
This also contains an escapement reversal (without known incidence on the plugin’s behavior).

= 2.6.1 =
- Bugfix: Tooltips: Styling: Font color: set to black for maximum contrast with respect to white default background, thanks to 4msc bug report.
- Bugfix: Tooltips: Styling: Background color: set default value back to white because empty doesn’t work out as expected.

= Branches =
Delete the staging branch.
Rationale:

- It is outdated an cannot be used for staging any more.
- It had been made improperly on its own instead of copying from trunk/.
- It is undue for the following reasons:
  - Staging release processes here is too dangerous.
  - Staging release processes here is too little effective.

Staging must not take place in this repository but in another SVN instance.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2504324 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-27 06:10:08 +00:00
pewgeuges
0dc4c08dd8 Unreleased bugfix v2.5.13 with Stable Tag 2.5.10.
= 2.5.13 =
- Bugfix: Dashboard: Backlink symbol: debug select box by reverting identity check to equality check, thanks to @lolzim bug report.
- Bugfix: Footnote delimiter short codes: debug closing pointy brackets in the Block Editor by accounting for unbalanced HTML escapement.
- Update: Dashboard: General settings: Footnote start and end short codes: update information about short codes using pointy brackets.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2502882 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-24 21:19:07 +00:00
pewgeuges
9e8e28412e Urgent unreleased bugfix version 2.5.12 with Stable Tag 2.5.10.
= 2.5.12 =
- Update: Scrolling: CSS-based smooth scroll behavior (optional), thanks to @paulgpetty and @bogosavljev issue reports.
- Bugfix: Backlinks: reflect scroll functions down/up differentiation across the template set, thanks to @bogosavljev bug report.
- Bugfix: Referrers: Hard links: enforce scroll offset with '!important' property for surroundings specifying otherwise, thanks to @bogosavljev bug report.
- Bugfix: Forms: prevent inadvertently toggling input elements with footnotes in their label, by optionally moving footnotes after the end of the label.
- Bugfix: Forms: prevent inadvertently toggling input elements with footnotes in their label, by optionally disconnecting those labels.
- Bugfix: Scroll offset: correct syntax error in the main style sheet.
- Bugfix: Reference container: correct new syntax errors in the 8 reference container row templates.
- Bugfix: Reference container: correct a new typo in the JavaScript reference container template.
- Update: Dashboard: General settings: split a dedicated 'URL fragment ID configuration' metabox off the 'Scrolling behavior' metabox.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2501451 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-23 04:02:07 +00:00
pewgeuges
ce42420149 Stable Tag remains 2.5.10 as this urgent bugfix v2.5.11 is tagged while 2.6.0 isn’t ready yet.
= 2.5.11 =
- Bugfix: Forms: remove footnotes from input field values, thanks to @bogosavljev bug report.
- Bugfix: Reference container: apply web semantics to improve readability for assistive technologies, thanks to @derivationfr issue report and code contribution.
- Bugfix: Tooltips: Styling: Background color: empty default value to adopt theme background, thanks to 4msc bug report.
- Bugfix: Dashboard: debug text input fields by disabling quotation mark escapement, thanks to @rumperuu code contribution in the standards compliance overhaul.
- Update: Documentation: Readme.txt: comment line below the 'Stable Tag' field to warn that this field is (unintuitively) parsed for release configuration.
- Update: Documentation: Readme.txt: informative 'Version' field in sync with 'Version' in 'footnotes.php' for bugfix versions available ahead of the Stable Tag.
- Update: Documentation: Readme.txt: informative 'Package Version' field in sync with the 'Package V.' field added in the 'footnotes.php' file header.
- Update: Codebase: make PHP code comply to WordPress PHP Coding Standards requirements, thanks to @rumperuu code contribution and refactoring.
- Bugfix: Forms: mitigate the adverse effect of clicking footnote referrers in labels of input elements by an optional, configurable scroll down delay.
- Bugfix: Scroll durations: mitigate the downside of delayed scrolling down by optionally enabling asymmetric scroll durations (e.g. fast down, slower up).
- Update: Scroll delays: add a setting to configure also a scroll up delay for completeness.
- Bugfix: Tooltips: Styling: protect padding against removal in surroundings with explicit zero padding.
- Bugfix: Tooltips: Display: CSS transitions: fix syntax error.
- Update: Documentation: help and support for contributors by the means of Contributing Guidelines in 'CONTRIBUTING.md', thanks to @rumperuu code contribution.
- Update: Documentation: additional readme in markdown format 'README.md' for use with the code repository on GitHub, thanks to @rumperuu code contribution.
- Update: Documentation: move 'customized-template-stack.txt' and 'customized-documentation-schema.txt' from the 'development/' folder to root.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2500516 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-21 19:19:04 +00:00
pewgeuges
c93e6ff28d 2.5.11d7 with the new settings.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2500244 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-20 20:48:54 +00:00
pewgeuges
7aa9d8803f Urgent bugfix development 2.5.11d5 with ST 2.5.10.
On top of 2.6.0d7.
Debugs Footnotes for all input field values with footnotes coming in from field label.
Preparing unreleased tagged v2.5.11 in response to Forum support request.
Accessibility fixes and AMP compat enhancements not fully debugged yet, draft only.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2499807 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-19 23:58:23 +00:00
pewgeuges
ccb73fd421 Accessibility added, v2.6.0d6 (S.T. 2.5.10).
= Reference container semantics for assistive technology =
- Table header elements with row scope in the first column.
- Table caption invisible to sighted users but required for screen readers.
= Referrer accessibility =
- jQuery referrers are accessible but don’t show the tooltips on focus.
- AMP compatible tooltips show up on focus on navigatable referrers.
- Alternative tooltips now accessible on focus on now navigatable referrers.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2498648 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-18 10:53:57 +00:00
pewgeuges
c5a9af037a Development preview 2.6.0d1 with AMP compat at work.
Stable Tag is 2.5.10. v2.6.0d0 does already exist on SVN (2456650 2021-01-14).
Tooltip timing settings are not yet usable in AMP mode.
Tooltip transitions don’t work now, only delays, need to debug.
It’s late and we have a deadline, so this is committed as a preview.
Thanks for looking into it.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2497297 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-16 19:41:08 +00:00
pewgeuges
7b7b8547b1 Traceability update to move constant docblocks class/settings.php.
Delta version 2.5.11d4; Stable Tag: 2.5.10.
No changes but sorting by version number.
This makes sure that other changes coming after will be traceable in SVN.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2496283 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-15 20:03:16 +00:00
pewgeuges
3f78157481 Traceability update for trunk/ with Stable Tag 2.5.10.
Delta version 2.5.11d3.
Before sorting constants in settings.php by version number (@since tag).
The next commit is dedicated to moving constants and their docblocks in settings.php.
This replaces most of the list items in the file level docblock.
Moving blocks of code breaks traceability of changes, so it’s usually avoided.
WordPress plugins are supposed to maintain traceability in the SVN repo, which implies keeping changesets meaningful.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2496275 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-15 19:37:41 +00:00
pewgeuges
daf0a8612f WordPress Coding Standards compliance update. Stable Tag 2.5.10. Package version: 2.5.11d0.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2486043 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-03 18:58:03 +00:00
pewgeuges
dfcbdc6adc Undo last two commits affecting trunk/ but not the Stable Tag.
= Stable Tag value =
2.5.10 (unchanged)
= Commits undone =
- 2484038 (2021-03-02 05:29:18 +0000 (Tue, 02 Mar 2021)) committer: pewgeuges
-2484015 (2021-03-02 04:22:20 +0000 (Tue, 02 Mar 2021)) committer: pewgeuges
= Rationale =
By renaming a folder (and 3 out of 4 included files), the WordPress Coding Standards compliance upgrade (see changeset 2484015) has broken the traceability of the changes made to the following files:
- footnotes/trunk/class/dashboard/init.php
- footnotes/trunk/class/dashboard/layout.php
- footnotes/trunk/class/dashboard/subpage-diagnostics.php
- footnotes/trunk/class/dashboard/subpage-main.php

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2485882 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-03 15:15:55 +00:00
pewgeuges
c63d3f629f Update to standardised codebase as on GitHub origin/main/, 2.5.8. Stable Tag value set to 2.5.10 since it’s parsed to determine current release.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2484015 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-02 04:22:20 +00:00
pewgeuges
caf3e1136c Convert EOL from CRLF to LF.
to make footnotes/trunk/ diffable against the standardised codebase on GitHub markcheret/footnotes/.
Stable Tag remains 2.5.10.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483994 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-02 03:09:34 +00:00
pewgeuges
ba9d9bc535 Revert to 2.5.8 in the new Stable Tag 2.5.10.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483464 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 11:09:29 +00:00
8a859b61f7 Re-standardise codebase to WP Coding Standards (this time without the line ending changes)
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483354 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 07:57:12 +00:00
05d316ae15 Revert standardise codebase to WP Coding Standards
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483350 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 07:54:03 +00:00
6a5fcedac3 Standardise codebase to WP Coding Standards
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2483336 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-03-01 07:37:59 +00:00
pewgeuges
bf80a52c07 Edit file level docblocks. 2021-02-24 23:53:22 +01:00
526b5d096f Minor whitespace, commenting tweaks 2021-02-23 17:59:52 +00:00
9a8e7c0851 Update codebase to be WP Coding Standard-compliant.
This is a squashed copy of `wp-coding-standard--rebase` to try and fix the line-ending
diff issue we're having.
2021-02-23 16:44:18 +00:00
9ee72568ef Append line endings 2021-02-23 16:00:59 +00:00
pewgeuges
65874f089b update 2.5.6d4 in case it is tested in the related forum topic.\nFull changelog:\n= 2.5.6 =\n- Bugfix: Reference container: optional alternative expanding and collapsing without jQuery for use with hard links, thanks to @hopper87it @pkverma99 issue reports.\n- Bugfix: Alternative tooltips: shrink width to short content.\n- Update: Documentation: slightly revise / update the plugin’s welcome page on WordPress.org.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2478015 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-20 03:50:52 +00:00
pewgeuges
67c1f443ad development update 2.5.6d2 to prepare the newly promised bugfix release adding a reference container template not using jQuery, plain JS instead.\nThe following is the changelog as drafted for this release: \n= 2.5.6 =\n- Bugfix: Reference container: optional alternative expanding and collapsing without jQuery for use with hard links, thanks to @hopper87it issue report.\n- Update: Documentation: slightly revise / update the plugin’s welcome page on WordPress.org.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2477898 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-19 19:42:45 +00:00
pewgeuges
7f5499723b traceability update 2.5.6d1 revert space indent to tab.
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2477300 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-18 19:56:44 +00:00
pewgeuges
f8a87d5928 dev version implementing @lolzim’s bugfix 2.5.5d2
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2476267 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-17 10:58:28 +00:00
pewgeuges
d9e23677b0 traceability update 2.5.5d1
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2476187 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-17 09:33:04 +00:00
pewgeuges
3a341d36b2 development update 2.5.5d0 to be shared on the forum
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2475227 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-16 02:23:40 +00:00
pewgeuges
e328969abf update for urgent bugfix release 2.5.4 - preview
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2473889 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-12 17:09:45 +00:00
pewgeuges
eaaad12e9b prepare urgent bugfix release 2.5.4 - this: 2.5.4d7
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2473867 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-12 16:22:45 +00:00
pewgeuges
b009311766 prepare urgent bugfix release 2.5.4 - this: 2.5.4d6
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2473635 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-12 10:18:31 +00:00
pewgeuges
b9476b682e traceability update 2.5.4d5
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2472973 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-11 10:34:35 +00:00
pewgeuges
0612b76412 traceability update 2.5.4d4
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2472020 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-02-09 23:33:29 +00:00
pewgeuges
b34c0c12ab update with last changes (2.5.4d0)
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2463046 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-26 17:01:53 +00:00
pewgeuges
12a53754ab update for urgent bugfix upcoming 2.5.3
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2461253 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-23 00:25:35 +00:00
pewgeuges
1c7debbaf5 update with last changes (2.6.0d0)
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2456650 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-14 22:56:43 +00:00
pewgeuges
354b5439f0 update trunk/ in vue of urgent bugfix plus feature release 2.5.0
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2452163 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-07 21:21:29 +00:00
pewgeuges
82cb6d5268 development 2.4.0d0 needed for support
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2449533 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-03 20:03:51 +00:00
pewgeuges
919e76bdef development 2.3.1d0 for forum
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2448740 b8457f37-d9ea-0310-8a92-e5e31aec5664
2021-01-01 05:52:49 +00:00
pewgeuges
62f3b5c360 release overdue 2.3.0
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2448566 b8457f37-d9ea-0310-8a92-e5e31aec5664
2020-12-31 14:15:16 +00:00
pewgeuges
442ae6f88f development preview 2.3.0
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2448470 b8457f37-d9ea-0310-8a92-e5e31aec5664
2020-12-31 11:45:10 +00:00
pewgeuges
1cb44eccd5 urgent bugfix release 2.2.10 in response to forum
git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2446030 b8457f37-d9ea-0310-8a92-e5e31aec5664
2020-12-25 23:00:23 +00:00