Preparing bugfix release 2.0.5 everything complete

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2411425 b8457f37-d9ea-0310-8a92-e5e31aec5664
2020-11-02 20:10:18 +00:00 · 2020-11-02 20:10:18 +00:00 · ddb568805b
parent 6a199cec73
commit ddb568805b
6 changed files with 77 additions and 46 deletions
--- a/class/init.php
+++ b/class/init.php
@ -10,8 +10,9 @@
 * 
 * Edited for v2.0.0: Added jQueryUI from CDN   2020-10-26T1907+0100
 * Edited for v2.0.3: Added style sheet versioning   2020-10-29T1413+0100
- * Edited for v2.0.4: Enqueuing settings.css   2020-11-01T0317+0100
 * Edited for v2.0.4: Added jQuery UI from WordPress   2020-11-01T1902+0100
+ * 
+ * Last modified:   2020-11-02T2003+0100
 */


@ -64,6 +65,14 @@ class MCI_Footnotes {
     *
     * @author Stefan Herndler
     * @since 1.5.0
+	 * 
+	 * Edited for 1.6.5: replaced deprecated function create_function()
+	 * 
+	 * Contributed by Felipe Lavín Z.   Thankfully acknowledged.
+	 * 
+	 * Deprecated in PHP 7.2
+	 * See <https://wordpress.org/support/topic/deprecated-in-php-7-2-function-create_function-is-deprecated/>
+	 * See also: <https://wordpress.org/support/topic/deprecated-function-create_function-14/>
     */
    public function initializeWidgets() {
      register_widget("MCI_Footnotes_Widget_ReferenceContainer");
@ -106,8 +115,7 @@ class MCI_Footnotes {
        
        // add the jQuery plugin (already registered by WordPress)
        wp_enqueue_script( 'jquery' );
-		
-        // Add jQueryUI: 'no need to enqueue -core, because dependancies are set'
+        // Add jQueryUI: 'no need to enqueue -core, because dependencies are set'
        wp_enqueue_script( 'jquery-ui-widget' );
        wp_enqueue_script( 'jquery-ui-mouse' );
        wp_enqueue_script( 'jquery-ui-accordion' );
@ -118,7 +126,6 @@ class MCI_Footnotes {
        wp_enqueue_script('mci-footnotes-js-jquery-tools', plugins_url('../js/jquery.tools.min.js', __FILE__));
        
        // IMPORTANT: up-to-date plugin version number for cache busting.
-        wp_enqueue_style('mci-footnotes-css-public',   plugins_url('../css/public.css',   __FILE__), '', '2.0.4');
-        wp_enqueue_style('mci-footnotes-css-settings', plugins_url('../css/settings.css', __FILE__), '', '2.0.4');
+        wp_enqueue_style('mci-footnotes-css-public',   plugins_url('../css/public.css',   __FILE__), '', '2.0.5');
    }
 }
--- a/class/settings.php
+++ b/class/settings.php
@ -407,13 +407,15 @@ class MCI_Footnotes_Settings {
 			self::C_STR_HYPERLINK_ARROW_USER_DEFINED => '',
 			self::C_STR_CUSTOM_CSS => ''
 		),
+		// These should all be enabled by default.
+		// See <https://wordpress.org/support/topic/more-feature-ideas/>
        "footnotes_storage_expert" => array(
-            self::C_BOOL_EXPERT_LOOKUP_THE_TITLE => '',
+            self::C_BOOL_EXPERT_LOOKUP_THE_TITLE => 'yes',
            self::C_BOOL_EXPERT_LOOKUP_THE_CONTENT => 'yes',
            self::C_BOOL_EXPERT_LOOKUP_THE_EXCERPT => 'yes',
-            self::C_BOOL_EXPERT_LOOKUP_WIDGET_TITLE => '',
+            self::C_BOOL_EXPERT_LOOKUP_WIDGET_TITLE => 'yes',
            self::C_BOOL_EXPERT_LOOKUP_WIDGET_TEXT => 'yes',
-            self::C_BOOL_EXPERT_LOOKUP_THE_POST => ''
+            self::C_BOOL_EXPERT_LOOKUP_THE_POST => 'yes'
        )
 	);

--- a/class/task.php
+++ b/class/task.php
@ -7,7 +7,8 @@
 * @since 1.5.0
 * 
 * Edited for v2.0.0 and following.
- * Last modified   2020-11-01T1945+0100
+ * 
+ * Last modified   2020-11-02T1147+0100
 */

 // If called directly, abort:
@ -53,31 +54,40 @@ class MCI_Footnotes_Task {
     *
     * @author Stefan Herndler
     * @since 1.5.0
+	 * 
+	 * Edited for v2.0.5   2020-11-02T0330+0100
+	 * 
+	 * Explicitly set all priority to default "10" instead of lowest "PHP_INT_MAX", 
+	 * especially for the_content, or footnotes won’t display beneath the content but 
+	 * below other features added by other plugins.
+	 * Although the default, 10 seems to suffice.
+	 * Requested by users: <https://wordpress.org/support/topic/change-the-position-5/>
+	 * Documentation: <https://codex.wordpress.org/Plugin_API/#Hook_in_your_Filter>
     */
    public function registerHooks() {
        // append custom css to the header
-        add_filter('wp_head', array($this, "wp_head"), PHP_INT_MAX);
+        add_filter('wp_head', array($this, "wp_head"), 10);

        // append the love and share me slug to the footer
-        add_filter('wp_footer', array($this, "wp_footer"), PHP_INT_MAX);
+        add_filter('wp_footer', array($this, "wp_footer"), 10);

        if (MCI_Footnotes_Convert::toBool(MCI_Footnotes_Settings::instance()->get(MCI_Footnotes_Settings::C_BOOL_EXPERT_LOOKUP_THE_TITLE))) {
-            add_filter('the_title', array($this, "the_title"), PHP_INT_MAX);
+            add_filter('the_title', array($this, "the_title"), 10);
        }
        if (MCI_Footnotes_Convert::toBool(MCI_Footnotes_Settings::instance()->get(MCI_Footnotes_Settings::C_BOOL_EXPERT_LOOKUP_THE_CONTENT))) {
-            add_filter('the_content', array($this, "the_content"), PHP_INT_MAX);
+            add_filter('the_content', array($this, "the_content"), 10);
        }
        if (MCI_Footnotes_Convert::toBool(MCI_Footnotes_Settings::instance()->get(MCI_Footnotes_Settings::C_BOOL_EXPERT_LOOKUP_THE_EXCERPT))) {
-             add_filter('the_excerpt', array($this, "the_excerpt"), PHP_INT_MAX);
+             add_filter('the_excerpt', array($this, "the_excerpt"), 10);
        }
        if (MCI_Footnotes_Convert::toBool(MCI_Footnotes_Settings::instance()->get(MCI_Footnotes_Settings::C_BOOL_EXPERT_LOOKUP_WIDGET_TITLE))) {
-            add_filter('widget_title', array($this, "widget_title"), PHP_INT_MAX);
+            add_filter('widget_title', array($this, "widget_title"), 10);
        }
        if (MCI_Footnotes_Convert::toBool(MCI_Footnotes_Settings::instance()->get(MCI_Footnotes_Settings::C_BOOL_EXPERT_LOOKUP_WIDGET_TEXT))) {
-            add_filter('widget_text', array($this, "widget_text"), PHP_INT_MAX);
+            add_filter('widget_text', array($this, "widget_text"), 10);
        }
        if (MCI_Footnotes_Convert::toBool(MCI_Footnotes_Settings::instance()->get(MCI_Footnotes_Settings::C_BOOL_EXPERT_LOOKUP_THE_POST))) {
-            add_filter('the_post', array($this, "the_post"), PHP_INT_MAX);
+            add_filter('the_post', array($this, "the_post"), 10);
        }
        // reset stored footnotes when displaying the header
        self::$a_arr_Footnotes = array();
--- a/css/public.css
+++ b/css/public.css
@ -4,8 +4,9 @@
 * Created-Date: 15.05.14
 * Created-Time: 16:21
 * Since: 1.0
- * Version: 2.0.4
- * Last modified: 2020-11-01T0536+0100
+ * Version: 2.0.5
+ *
+ * Last modified: 2020-11-02T2050+0100
 */
 
 
@ -63,6 +64,7 @@ span.footnote_tooltip {
    font-style: italic;
    color: green;
    text-decoration: none !important;
+    cursor: pointer;
 }
 .continue:hover {
    color: blue;
@ -148,6 +150,9 @@ span.footnote_tooltip {
        max-width: 100px;
    }
 }
+.footnote_plugin_text {
+	width: unset;        /*unset width of text column to fix site issues*/
+}

 /* Footnotes printing style rules
 *
--- a/footnotes.php
+++ b/footnotes.php
@ -4,7 +4,7 @@
    Plugin URI: https://wordpress.org/plugins/footnotes/
    Description: time to bring footnotes to your website! footnotes are known from offline publishing and everybody takes them for granted when reading a magazine.
    Author: Mark Cheret
-    Version: 2.0.4
+    Version: 2.0.5
    Author URI: http://cheret.de/plugins/footnotes-2/
    Text Domain: footnotes
    Domain Path: /languages
--- a/readme.txt
+++ b/readme.txt
@ -4,7 +4,7 @@ Tags: footnote, footnotes, bibliography, formatting, notes, Post, posts, referen
 Requires at least: 3.9
 Tested up to: 5.5
 Requires PHP: 5.6
-Stable Tag: 2.0.4
+Stable Tag: 2.0.5
 License: GPLv3 or later
 License URI: http://www.gnu.org/licenses/gpl-3.0.html

@ -80,6 +80,13 @@ Visit this swift write-up from a **footnotes** user by the name of **Southwest**

 == Changelog ==

+= 2.0.5 =
+- Bugfix: Input boxes on public pages
+- Bugfix: Get references container close to content, not below all other features
+- Bugfix: Public style sheet: Reference container: unset width of text column to fix site issues
+- Update: Enable all hooks by default to prevent footnotes from seeming broken in post titles
+- Bugfix: Restore cursor shape pointer over 'Continue reading' button after hyperlink removal
+
 = 2.0.4 =
 - Update: Restored arrow settings to customize or disable the now prepended arrow symbol
 - Update: GDPR: Added jQuery UI from WordPress instead of third party