- Release urgent bugfix v2.6.6

- Delete temporary tag 2.5.13.1
= 2.6.6 =
- Bugfix: Process: fix issue that caused some footnotes to not be processed, thanks to @docteurfitness @rkupadhya @offpeakdesign bug reports.

git-svn-id: https://plugins.svn.wordpress.org/footnotes/trunk@2513893 b8457f37-d9ea-0310-8a92-e5e31aec5664

class/task.php

@@ -2154,12 +2154,11 @@ class MCI_Footnotes_Task {
 			}
 
 			/**
-			 * Fixes a footnotes numbering bug (happening under de facto rare circumstances).
+			 * Fixes a partial footnotes process outage happening when tooltips are truncated or disabled.
+			 * Fixed a footnotes numbering bug happening under de facto rare circumstances.
 			 *
 			 * - Bugfix: Fixed occasional bug where footnote ordering could be out of sequence
 			 *
-			 * @since 1.6.4
-			 * @date 2016-06-29T0054+0000
 			 * @committer @dartiss
 			 * @link https://plugins.trac.wordpress.org/browser/footnotes/trunk/class/task.php?rev=1445718 @dartiss’ class/task.php
 			 * @link https://plugins.trac.wordpress.org/log/footnotes/trunk/class/task.php?rev=1445718 @dartiss re-added class/task.php
@@ -2167,6 +2166,8 @@ class MCI_Footnotes_Task {
 			 * @link https://plugins.trac.wordpress.org/changeset/1445711/footnotes/trunk/class @dartiss deleted class/task.php
 			 * @link https://plugins.trac.wordpress.org/browser/footnotes/trunk/class/task.php?rev=1026210 @aricura’s latest class/task.php
 			 *
+			 * @since 1.6.4
+			 * @date 2016-06-29T0054+0000
 			 *
 			 * - Bugfix: Process: fix numbering bug impacting footnote #2 with footnote #1 close to start, thanks to @rumperuu bug report, thanks to @lolzim code contribution.
 			 *
@@ -2182,10 +2183,33 @@ class MCI_Footnotes_Task {
 			 * footnote and the length of the last footnote replace text.
 			 * A bug disturbing the order of the footnotes depending on the text before the first
 			 * footnote, the length of the first footnote and the length of the templates for the
-			 * footnote and the tooltip. Moreover, it was causing non-trivial process garbage.
+			 * footnote and the tooltip.
+			 * Deleting both lines instead, to resume the search at the position where it left off,
+			 * would have prevented also the following bug.
+			 *
+			 * - Bugfix: Process: fix issue that caused some footnotes to not be processed, thanks to @docteurfitness @rkupadhya @offpeakdesign bug reports.
+			 *
+			 * @reporter @docteurfitness
+			 * @link https://wordpress.org/support/topic/problem-since-footnotes-2-5-14/
+			 *
+			 * @reporter @rkupadhya
+			 * @link https://wordpress.org/support/topic/adjacent-footnotes-not-working-sometimes/
+			 *
+			 * @reporter @offpeakdesign
+			 * @link https://wordpress.org/support/topic/character-limit-bug/
+			 *
+			 * @since 2.6.6
+			 * The origin of the bug was present since the beginning (v1.0.0).
+			 * For v1.3.2 the wrong code was refactored but remained wrong,
+			 * and was unaffected by the v1.5.0 refactoring.
+			 * The reason why the numbering disorder reverted to a partial process outage
+			 * since 2.5.14 is that with this version, the plugin stopped processing the
+			 * content multiple times, and started unifying the shortcodes instead, to fix
+			 * the numbering disorder affecting delimiter shortcodes with pointy brackets
+			 * and mixed escapement schemas.
 			 */
 			// Add offset to the new starting position.
-			$l_int_pos_start += $l_int_length + strlen( self::$a_str_end_tag );
+			$l_int_pos_start += strlen( $l_str_footnote_replace_text );
 
 		} while ( true );
 

footnotes.php

@@ -4,8 +4,8 @@
  * Plugin URI: https://wordpress.org/plugins/footnotes/
  * Description: time to bring footnotes to your website! footnotes are known from offline publishing and everybody takes them for granted when reading a magazine.
  * Author: Mark Cheret
- * Package V.: 2.6.5
+ * Package V.: 2.6.6
- * Version: 2.6.5
+ * Version: 2.6.6
  * CAUTION: THIS V. FIELD IS PARSED FOR UPDATE CONFIGURATION.
  * Author URI: https://cheret.org/footnotes/
  * Text Domain: footnotes
@@ -21,9 +21,9 @@
  * @since 2.1.4
  * @since 2.5.3 (Hungarian)
  * @var str
- * @lastmodified 2021-04-01T0721+0200
+ * @lastmodified 2021-04-13T1011+0200
  */
-define( 'C_STR_PACKAGE_VERSION', '2.6.5' );
+define( 'C_STR_PACKAGE_VERSION', '2.6.6' );
 /**
  * Enables toggling the stylesheet enqueuing mode from production (true) to development (false).
  * @see Full docblock below next.

js/wysiwyg-editor.js

@@ -69,7 +69,7 @@
 				author : 'Mark Cheret',
 				authorurl : 'https://cheret.org/footnotes/',
 				infourl : 'https://wordpress.org/plugins/footnotes/',
-				version : '2.6.5'
+				version : '2.6.6'
 			};
 		}
 	});

readme.txt

@@ -3,10 +3,10 @@ Contributors: mark.cheret, lolzim, rumperuu, aricura, misfist, ericakfranz, mili
 Tags: footnote, footnotes, bibliography, formatting, notes, Post, posts, reference, referencing
 Requires at least: 3.9
 Tested up to: 5.7
-Requires PHP: 5.6
+Requires PHP: 7.0
-Package Version: 2.6.5
+Package Version: 2.6.6
-Version: 2.6.5
+Version: 2.6.6
-Stable Tag: 2.6.5
+Stable Tag: 2.6.6
 CAUTION: THE S. T. FIELD IS PARSED FOR RELEASE CONFIGURATION.
 License: GPLv3 or later
 License URI: https://www.gnu.org/licenses/gpl-3.0.html
@@ -80,6 +80,9 @@ Visit this swift write-up from a **footnotes** user by the name of **Southwest**
 
 == Changelog ==
 
+= 2.6.6 =
+- Bugfix: Process: fix issue that caused some footnotes to not be processed, thanks to @docteurfitness @rkupadhya @offpeakdesign bug reports.
+
 = 2.6.5 =
 - Bugfix: Editor buttons: debug button by reverting name change in PHP file while JS file and HTML template remained unsynced, thanks to @gova bug report.
 - Bugfix: Hooks: default-disable the_excerpt hook with respect to theme-specific excerpt handling, thanks to @mmallett bug reports.