Rumperuu/footnotes
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix: fix variable clash

Browse source
This commit is contained in:
Ben Goldsworthy 2021-05-02 21:21:32 +01:00
parent 114121a7e2
commit a5e4764a35
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/admin/layout/class-engine.php
View file

@ -417,11 +417,11 @@ abstract class Engine {
protected function add_select_box( string $setting_name, array $options ): string { protected function add_select_box( string $setting_name, array $options ): string {
// Collect data for given settings field. // Collect data for given settings field.
$data = $this->load_setting( $setting_name ); $data = $this->load_setting( $setting_name );
$options = ''; $select_options = '';
// Loop through all array keys. // Loop through all array keys.
foreach ( $options as $value => $caption ) { foreach ( $options as $value => $caption ) {
$options .= sprintf( $select_options .= sprintf(
'<option value="%s" %s>%s</option>', '<option value="%s" %s>%s</option>',
$value, $value,
// Only check for equality, not identity, WRT backlink symbol arrows. // Only check for equality, not identity, WRT backlink symbol arrows.
@ -435,7 +435,7 @@ abstract class Engine {
'<select name="%s" id="%s">%s</select>', '<select name="%s" id="%s">%s</select>',
$data['name'], $data['name'],
$data['id'], $data['id'],
$options $select_options
); );
} }