Rumperuu/footnotes
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Take function calls out of for loops

Browse source
This commit is contained in:
Ben Goldsworthy 2021-02-21 12:13:20 +00:00
parent 63c9de0e4e
commit a205f63896
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
class/settings.php
View file

@ -1094,7 +1094,8 @@ class MCI_Footnotes_Settings {
private function load_all() { private function load_all() {
// Clear current settings. // Clear current settings.
$this->a_arr_settings = array(); $this->a_arr_settings = array();
for ( $i = 0; $i < count( $this->a_arr_container ); $i++ ) { $num_settings = count( $this->a_arr_container );
for ( $i = 0; $i < $num_settings; $i++ ) {
// Load settings. // Load settings.
$this->a_arr_settings = array_merge( $this->a_arr_settings, $this->load( $i ) ); $this->a_arr_settings = array_merge( $this->a_arr_settings, $this->load( $i ) );
} }
@ -1180,7 +1181,8 @@ class MCI_Footnotes_Settings {
*/ */
public function clear_all() { public function clear_all() {
// Iterate through each Settings Container. // Iterate through each Settings Container.
for ( $i = 0; $i < count( $this->a_arr_container ); $i++ ) { $num_settings = count( $this->a_arr_container );
for ( $i = 0; $i < $num_settings; $i++ ) {
// Delete the settings container. // Delete the settings container.
delete_option( $this->get_container( $i ) ); delete_option( $this->get_container( $i ) );
} }
@ -1196,7 +1198,8 @@ class MCI_Footnotes_Settings {
*/ */
public function register_settings() { public function register_settings() {
// Register all settings. // Register all settings.
for ( $i = 0; $i < count( $this->a_arr_container ); $i++ ) { $num_settings = count( $this->a_arr_container );
for ( $i = 0; $i < $num_settings; $i++ ) {
register_setting( $this->get_container( $i ), $this->get_container( $i ) ); register_setting( $this->get_container( $i ), $this->get_container( $i ) );
} }
} }