refactor: add strict typing

This commit is contained in:
Ben Goldsworthy 2021-05-02 19:33:29 +01:00
parent c1421d1978
commit 9aae69a693
19 changed files with 83 additions and 49 deletions

View file

@ -25,6 +25,8 @@
* @since 2.8.0
*/
declare(strict_types=1);
namespace footnotes\includes;
/**

View file

@ -29,6 +29,8 @@
* @deprecated
*/
declare(strict_types=1);
namespace footnotes\includes;
/**

View file

@ -8,6 +8,8 @@
* rename `class/` sub-directory to `includes/`.
*/
declare(strict_types=1);
namespace footnotes\includes;
/**
@ -40,7 +42,7 @@ class Convert {
return self::to_arabic_leading( $p_int_index );
case 'arabic_plain':
default:
return $p_int_index;
return (string) $p_int_index;
}
}

View file

@ -27,6 +27,8 @@
* Renamed parent `class/` directory to `includes/`.
*/
declare(strict_types=1);
namespace footnotes\includes;
use footnotes\general as General;

View file

@ -6,6 +6,8 @@
* @since 2.8.0
*/
declare(strict_types=1);
namespace footnotes\includes;
/**

View file

@ -8,6 +8,8 @@
* rename `class/` sub-directory to `includes/`.
*/
declare(strict_types=1);
namespace footnotes\includes;
require_once plugin_dir_path( dirname( __FILE__ ) ) . 'includes/class-config.php';

View file

@ -7,6 +7,8 @@
* @since 2.8.0
*/
declare(strict_types=1);
namespace footnotes\includes;
/**

View file

@ -8,6 +8,8 @@
* Renamed parent `class/` directory to `includes/`.
*/
declare(strict_types=1);
namespace footnotes\includes;
/**

View file

@ -11,6 +11,8 @@
* rename `class/` sub-directory to `includes/`.
*/
declare(strict_types=1);
namespace footnotes\includes;
/**
@ -120,7 +122,7 @@ class Template {
}
// Iterate through each placeholder and replace it with its value.
foreach ( $p_arr_placeholders as $l_str_placeholder => $l_str_value ) {
$this->a_str_replaced_content = str_replace( '[[' . $l_str_placeholder . ']]', $l_str_value, $this->a_str_replaced_content );
$this->a_str_replaced_content = str_replace( '[[' . $l_str_placeholder . ']]', (string) $l_str_value, $this->a_str_replaced_content );
}
// Success.
return true;