fix: fix bug that caused footnotes to not be processed (#75)

This commit is contained in:
Ben Goldsworthy 2021-04-12 21:10:23 +01:00 committed by GitHub
parent cdb4dc0fea
commit 50115fb6c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions

View file

@ -2161,7 +2161,6 @@ class MCI_Footnotes_Task {
* - Bugfix: Fixed occasional bug where footnote ordering could be out of sequence * - Bugfix: Fixed occasional bug where footnote ordering could be out of sequence
* *
* @since 1.6.4 * @since 1.6.4
* @date 2016-06-29T0054+0000
* @committer @dartiss * @committer @dartiss
* @link https://plugins.trac.wordpress.org/browser/footnotes/trunk/class/task.php?rev=1445718 @dartiss class/task.php * @link https://plugins.trac.wordpress.org/browser/footnotes/trunk/class/task.php?rev=1445718 @dartiss class/task.php
* @link https://plugins.trac.wordpress.org/log/footnotes/trunk/class/task.php?rev=1445718 @dartiss re-added class/task.php * @link https://plugins.trac.wordpress.org/log/footnotes/trunk/class/task.php?rev=1445718 @dartiss re-added class/task.php
@ -2169,7 +2168,6 @@ class MCI_Footnotes_Task {
* @link https://plugins.trac.wordpress.org/changeset/1445711/footnotes/trunk/class @dartiss deleted class/task.php * @link https://plugins.trac.wordpress.org/changeset/1445711/footnotes/trunk/class @dartiss deleted class/task.php
* @link https://plugins.trac.wordpress.org/browser/footnotes/trunk/class/task.php?rev=1026210 @aricuras latest class/task.php * @link https://plugins.trac.wordpress.org/browser/footnotes/trunk/class/task.php?rev=1026210 @aricuras latest class/task.php
* *
*
* - Bugfix: Process: fix numbering bug impacting footnote #2 with footnote #1 close to start, thanks to @rumperuu bug report, thanks to @lolzim code contribution. * - Bugfix: Process: fix numbering bug impacting footnote #2 with footnote #1 close to start, thanks to @rumperuu bug report, thanks to @lolzim code contribution.
* *
* @reporter @rumperuu * @reporter @rumperuu
@ -2185,9 +2183,14 @@ class MCI_Footnotes_Task {
* A bug disturbing the order of the footnotes depending on the text before the first * A bug disturbing the order of the footnotes depending on the text before the first
* footnote, the length of the first footnote and the length of the templates for the * footnote, the length of the first footnote and the length of the templates for the
* footnote and the tooltip. Moreover, it was causing non-trivial process garbage. * footnote and the tooltip. Moreover, it was causing non-trivial process garbage.
*
* @since 2.6.6
* Fix bug that caused some footnotes to not be processed.
* @reporter @docteurfitness
* @link https://wordpress.org/support/topic/problem-since-footnotes-2-5-14/
*/ */
// Add offset to the new starting position. // Add offset to the new starting position.
$l_int_pos_start += $l_int_length + strlen( self::$a_str_end_tag ); $l_int_pos_start += strlen( $l_str_footnote_replace_text );
} while ( true ); } while ( true );

View file

@ -77,6 +77,9 @@ Visit this swift write-up from a **footnotes** user by the name of **Southwest**
== Changelog == == Changelog ==
= 2.6.6 =
- Bugfix: Process: fix issue that caused some footnotes to not be processed, thanks to @docteurfitness bug report.
= 2.6.5 = = 2.6.5 =
- Bugfix: Editor buttons: debug button by reverting name change in PHP file while JS file and HTML template remained unsynced, thanks to @gova bug report. - Bugfix: Editor buttons: debug button by reverting name change in PHP file while JS file and HTML template remained unsynced, thanks to @gova bug report.
- Bugfix: Hooks: default-disable the_excerpt hook with respect to theme-specific excerpt handling, thanks to @mmallett bug reports. - Bugfix: Hooks: default-disable the_excerpt hook with respect to theme-specific excerpt handling, thanks to @mmallett bug reports.