From 0f1440d772d7b0e22fa37725bc34b6c77e4de3e5 Mon Sep 17 00:00:00 2001 From: Mark Cheret Date: Sun, 21 Feb 2021 13:54:54 +0100 Subject: [PATCH 1/4] Update CONTRIBUTING.md --- CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 73fa4de..d631099 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,19 +1,19 @@ -footnotes welcomes contributions! +***footnotes*** welcomes contributions! Please follow these guidelines when contributing, as it will give your pull request the best chance of being accepted: # Branching -- footnotes uses [GitHub Flow](https://githubflow.github.io/) +- ***footnotes*** uses [GitHub Flow](https://githubflow.github.io/) - branch off of `main` to start developing - give your new branch a descriptive name - when ready, submit a pull request to merge your branch with `main` # Commits -- footnotes uses [Conventional Commits](https://www.conventionalcommits.org) +- ***footnotes*** uses [Conventional Commits](https://www.conventionalcommits.org) - keep individual commits as small as possible # Versioning -- footnotes uses [Semantic Versioning](https://semver.org/) +- ***footnotes*** uses [Semantic Versioning](https://semver.org/) From b00d47b757930dcf6949752d8f637d609f608445 Mon Sep 17 00:00:00 2001 From: Mark Cheret Date: Sun, 21 Feb 2021 13:58:08 +0100 Subject: [PATCH 2/4] Update README.md --- README.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 2ff05d5..baabd72 100644 --- a/README.md +++ b/README.md @@ -6,19 +6,19 @@ Featured on [wpmudev](http://premium.wpmudev.org/blog/12-surprisingly-useful-wordpress-plugins-you-dont-know-about/) --- cheers for the review, folks! -**footnotes** aims to be the all-in-one solution for displaying an automatically generated list of references on your Page or Post. The Plugin ships with a set of current defaults but also empowers you to control how your footnotes are being displayed. +***footnotes*** aims to be the all-in-one solution for displaying an automatically generated list of references on your Page or Post. The Plugin ships with a set of current defaults but also empowers you to control how your footnotes are being displayed. -**footnotes** gives you the ability to display well-formatted footnotes on your WordPress Pages and Posts—those footnotes we know from offline publishing. +***footnotes*** gives you the ability to display well-formatted footnotes on your WordPress Pages and Posts—those footnotes we know from offline publishing. ## Getting Started 1. Read the contributing guidelines -1. Clone this repository (`git clone git@github.com:Rumperuu/footnotes.git`) +1. Clone this repository (`git clone git@github.com:markcheret/footnotes.git`) 1. Install [Composer](https://getcomposer.org/download/), if you don't have it already 1. Install dependencies (`composer install`) 1. Create a new branch from `main` (`git checkout -b `) 1. When you're finished, commit your changes to the remote version of your branch - and submit a [pull request](https://github.com/Rumperuu/footnotes/pulls). + and submit a [pull request](https://github.com/markcheret/footnotes/pulls). ## Checking WP Coding Standard Compliance @@ -39,13 +39,13 @@ Unit tests are TODO. ## Main Features -- Fully customizable **footnotes** start and end shortcodes; -- Styled tooltips supporting hyperlinks display **footnotes** or a dedicated text; +- Fully customizable ***footnotes*** start and end shortcodes; +- Styled tooltips supporting hyperlinks display ***footnotes*** or a dedicated text; - Responsive *Reference Container* at the end or positioned by shortcode; -- Display the **footnotes** *Reference Container* inside a Widget; +- Display the ***footnotes*** *Reference Container* inside a Widget; - Wide choice of numbering styles; - Freely configurable and optional backlink symbol; -- Configure the **footnotes’** appearance by dashboard settings and Custom CSS style rules; +- Configure the ***footnotes'*** appearance by dashboard settings and Custom CSS style rules; - Button in both the Visual and the Text editor to add shortcodes around selection. ## Example Usage @@ -63,4 +63,4 @@ The current version is available on the [WordPress.org Plugin Directory](https:/ ## Acknowledgements -Huge thanks to every footnotes user, contributor, bug reporter, feature requester and fan! +Huge thanks to every ***footnotes user***, contributor, bug reporter, feature requester and fan! From b11f3bdc2e332ff827b9c13c1a02f49907204ad1 Mon Sep 17 00:00:00 2001 From: Rumperuu Date: Sun, 21 Feb 2021 13:53:51 +0000 Subject: [PATCH 3/4] Alter formatting, add contribution information --- CONTRIBUTING.md | 36 +++++++++++++++++++++++++++--------- README.md | 14 +++++++------- 2 files changed, 34 insertions(+), 16 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d631099..5802338 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,19 +1,37 @@ -***footnotes*** welcomes contributions! +**footnotes** welcomes contributions! -Please follow these guidelines when contributing, as it will give your pull request the best chance of being accepted: +Please follow these guidelines when contributing, as it will give your pull +request the best chance of being accepted: -# Branching +# Requesting Features/Reporting Bugs -- ***footnotes*** uses [GitHub Flow](https://githubflow.github.io/) -- branch off of `main` to start developing -- give your new branch a descriptive name -- when ready, submit a pull request to merge your branch with `main` +- To request a new feature or to report a bug, create an + [Issue](https://github.com/markcheret/footnotes/issues/new/choose) and choose + the correct template + +# Contributing Code + +- **footnotes** uses [GitHub Flow](https://githubflow.github.io/) +- branch off of `main` to start developing (`git checkout -b `) +- ensure that your new branch has a descriptive name +- create a remote copy of your new branch (`git push`) +- create a draft [pull request](https://github.com/markcheret/footnotes/compare) + to merge your branch with `main` — tag any related Issues, and if they are + assigned to a Project board, this will automatically move them into the + ‘In Progress’ bucket +- when you think you're finished, un-draft your pull request — if the PR is + assigned to a Project board, this will automatically move it and any related + Issues into the ‘Review in progress’ bucket # Commits -- ***footnotes*** uses [Conventional Commits](https://www.conventionalcommits.org) +- **footnotes** uses [Conventional Commits](https://www.conventionalcommits.org) - keep individual commits as small as possible # Versioning -- ***footnotes*** uses [Semantic Versioning](https://semver.org/) +- **footnotes** uses [Semantic Versioning](https://semver.org/) + +# Translating + +- Translations are welcome! diff --git a/README.md b/README.md index baabd72..d3ec650 100644 --- a/README.md +++ b/README.md @@ -6,9 +6,9 @@ Featured on [wpmudev](http://premium.wpmudev.org/blog/12-surprisingly-useful-wordpress-plugins-you-dont-know-about/) --- cheers for the review, folks! -***footnotes*** aims to be the all-in-one solution for displaying an automatically generated list of references on your Page or Post. The Plugin ships with a set of current defaults but also empowers you to control how your footnotes are being displayed. +**footnotes** aims to be the all-in-one solution for displaying an automatically generated list of references on your Page or Post. The Plugin ships with a set of current defaults but also empowers you to control how your footnotes are being displayed. -***footnotes*** gives you the ability to display well-formatted footnotes on your WordPress Pages and Posts—those footnotes we know from offline publishing. +**footnotes** gives you the ability to display well-formatted footnotes on your WordPress Pages and Posts—those footnotes we know from offline publishing. ## Getting Started @@ -39,13 +39,13 @@ Unit tests are TODO. ## Main Features -- Fully customizable ***footnotes*** start and end shortcodes; -- Styled tooltips supporting hyperlinks display ***footnotes*** or a dedicated text; +- Fully customizable **footnotes** start and end shortcodes; +- Styled tooltips supporting hyperlinks display **footnotes** or a dedicated text; - Responsive *Reference Container* at the end or positioned by shortcode; -- Display the ***footnotes*** *Reference Container* inside a Widget; +- Display the **footnotes** *Reference Container* inside a Widget; - Wide choice of numbering styles; - Freely configurable and optional backlink symbol; -- Configure the ***footnotes'*** appearance by dashboard settings and Custom CSS style rules; +- Configure the **footnotes'** appearance by dashboard settings and Custom CSS style rules; - Button in both the Visual and the Text editor to add shortcodes around selection. ## Example Usage @@ -63,4 +63,4 @@ The current version is available on the [WordPress.org Plugin Directory](https:/ ## Acknowledgements -Huge thanks to every ***footnotes user***, contributor, bug reporter, feature requester and fan! +Huge thanks to every **footnotes user**, contributor, bug reporter, feature requester and fan! From 9d8efe1a414700fcfeec64ae9c5313fe032cd287 Mon Sep 17 00:00:00 2001 From: Rumperuu Date: Sun, 21 Feb 2021 13:55:22 +0000 Subject: [PATCH 4/4] Fix indentation --- CONTRIBUTING.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5802338..83e6a64 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,7 @@ request the best chance of being accepted: - To request a new feature or to report a bug, create an [Issue](https://github.com/markcheret/footnotes/issues/new/choose) and choose - the correct template + the correct template # Contributing Code @@ -17,11 +17,11 @@ request the best chance of being accepted: - create a remote copy of your new branch (`git push`) - create a draft [pull request](https://github.com/markcheret/footnotes/compare) to merge your branch with `main` — tag any related Issues, and if they are - assigned to a Project board, this will automatically move them into the - ‘In Progress’ bucket + assigned to a Project board, this will automatically move them into the + ‘In Progress’ bucket - when you think you're finished, un-draft your pull request — if the PR is - assigned to a Project board, this will automatically move it and any related - Issues into the ‘Review in progress’ bucket + assigned to a Project board, this will automatically move it and any related + Issues into the ‘Review in progress’ bucket # Commits