Use Yoda conditions (and strict comparisons), we must

This commit is contained in:
Ben Goldsworthy 2021-02-21 11:57:56 +00:00
parent 1b084bb52c
commit 2e311ed267
5 changed files with 32 additions and 32 deletions

View file

@ -68,7 +68,7 @@ class MCI_Footnotes_WYSIWYG {
// Get start and end tag for the footnotes short code.
$l_str_starting_tag = MCI_Footnotes_Settings::instance()->get( MCI_Footnotes_Settings::C_STR_FOOTNOTES_SHORT_CODE_START );
$l_str_ending_tag = MCI_Footnotes_Settings::instance()->get( MCI_Footnotes_Settings::C_STR_FOOTNOTES_SHORT_CODE_END );
if ( $l_str_starting_tag == 'userdefined' || $l_str_ending_tag == 'userdefined' ) {
if ( 'userdefined' === $l_str_starting_tag || 'userdefined' === $l_str_ending_tag ) {
$l_str_starting_tag = MCI_Footnotes_Settings::instance()->get( MCI_Footnotes_Settings::C_STR_FOOTNOTES_SHORT_CODE_START_USER_DEFINED );
$l_str_ending_tag = MCI_Footnotes_Settings::instance()->get( MCI_Footnotes_Settings::C_STR_FOOTNOTES_SHORT_CODE_END_USER_DEFINED );
}