diff --git a/class/task.php b/class/task.php index 13c416d..9389d9c 100644 --- a/class/task.php +++ b/class/task.php @@ -7,7 +7,7 @@ * @since 1.5.0 * * - * @lastmodified 2021-02-17T1142+0100 + * @lastmodified 2021-02-17T1754+0100 * * @since 2.0.0 Bugfix: various. * @since 2.0.4 Bugfix: Referrers and backlinks: remove hard links to streamline browsing history, thanks to @theroninjedi47 bug report. @@ -1700,12 +1700,22 @@ class MCI_Footnotes_Task { // increase footnote index $l_int_FootnoteIndex++; } - // add offset to the new starting position - $l_int_PosStart += $l_int_Length + strlen($l_str_EndingTag); /** * Fixes a footnotes numbering bug (happening under de facto rare circumstances). * + * - Bugfix: Fixed occasional bug where footnote ordering could be out of sequence + * + * @since 1.6.4 + * @date 2016-06-29T0054+0000 + * @committer @dartiss + * @link https://plugins.trac.wordpress.org/browser/footnotes/trunk/class/task.php?rev=1445718 @dartiss’ class/task.php + * @link https://plugins.trac.wordpress.org/log/footnotes/trunk/class/task.php?rev=1445718 @dartiss re-added class/task.php + * @link https://plugins.trac.wordpress.org/browser/footnotes/trunk/class?rev=1445711 class/ w/o task.php + * @link https://plugins.trac.wordpress.org/changeset/1445711/footnotes/trunk/class @dartiss deleted class/task.php + * @link https://plugins.trac.wordpress.org/browser/footnotes/trunk/class/task.php?rev=1026210 @aricura’s latest class/task.php + * + * * - Bugfix: Process: fix numbering bug impacting footnote #2 with footnote #1 close to start, thanks to @rumperuu bug report, thanks to @lolzim code contribution. * * @since 2.5.5 @@ -1716,12 +1726,15 @@ class MCI_Footnotes_Task { * @reporter @rumperuu * @link https://wordpress.org/support/topic/footnotes-numbered-incorrectly/ * - * This line caused the algorithm to jump back near the post start, disturbing - * the order of the footnotes depending on the text before the first footnote, - * the length of the first footnote and the length of the footnote and tooltip - * templates. + * This assignment was overridden by another one, causing the algorithm to jump back + * near the post start to a position calculated as the sum of the length of the last + * footnote and the length of the last footnote replace text. + * A bug disturbing the order of the footnotes depending on the text before the first + * footnote, the length of the first footnote and the length of the templates for the + * footnote and the tooltip. Moreover, it was causing non-trivial process garbage. */ - // $l_int_PosStart = $l_int_Length + strlen($l_str_FootnoteReplaceText); + // add offset to the new starting position + $l_int_PosStart += $l_int_Length + strlen($l_str_EndingTag); } while (true); diff --git a/class/widgets/base.php b/class/widgets/base.php index 39641a7..7e8ece1 100644 --- a/class/widgets/base.php +++ b/class/widgets/base.php @@ -1,9 +1,15 @@ __CLASS__, "description" => $this->getDescription()); diff --git a/footnotes.php b/footnotes.php index f20e7ef..1cda7f1 100755 --- a/footnotes.php +++ b/footnotes.php @@ -4,7 +4,7 @@ Plugin URI: https://wordpress.org/plugins/footnotes/ Description: time to bring footnotes to your website! footnotes are known from offline publishing and everybody takes them for granted when reading a magazine. Author: Mark Cheret - Version: 2.5.5 + Version: 2.5.6d0 Author URI: http://cheret.de/plugins/footnotes-2/ Text Domain: footnotes Domain Path: /languages @@ -18,10 +18,10 @@ * @since 2.1.4 * @since 2.5.3 (Hungarian) * @var str - * @lastmodified 2021-02-17T1232+0100 + * @lastmodified 2021-02-18T1919+0100 * @committer @pewgeuges */ -define( 'C_STR_FOOTNOTES_VERSION', '2.5.5' ); +define( 'C_STR_FOOTNOTES_VERSION', '2.5.6d0' ); /* LICENSE NOTICE diff --git a/readme.txt b/readme.txt index 4e62076..8ff4124 100755 --- a/readme.txt +++ b/readme.txt @@ -15,28 +15,26 @@ Cheers for the review, folks! https://www.youtube.com/watch?v=HzHaMAAJwbI -**footnotes** aims to be the all-in-one solution for displaying an automatically generated list of references on your Page or Post. The Plugin ships with a set of sane defaults but also gives the user control over how their footnotes are being displayed. -**footnotes** gives you the ability to display decently-formated footnotes on your WordPress Pages or Posts (those footnotes we know from offline publishing). +**footnotes** aims to be the all-in-one solution for displaying an automatically generated list of references on your Page or Post. The Plugin ships with a set of current defaults but also empowers you to control how your footnotes are being displayed. +**footnotes** gives you the ability to display well-formatted footnotes on your WordPress Pages and Posts—those footnotes we know from offline publishing. = Main Features = -- Fully customizable **footnotes** shortcode -- Decide, where your **footnotes** are displayed (position of the *Reference Container*) -- Add custom CSS to style the appeareance of the **footnotes** -- Responsive *Reference Container* -- Mouse-Over Box with clickable links displays your **footnotes** text -- Automatic numbering of your **footnotes** -- Choose from a list of symbols to represent your **footnotes** -- Display the **footnotes** *Reference Container* inside a Widget -- Button in both the Visual and the Text editor - - Add **footnotes** into your Page / Post with ease of use by selecting your text and clicking the button +- Fully customizable **footnotes** start and end shortcodes; +- Styled tooltips supporting hyperlinks display **footnotes** or a dedicated text; +- Responsive *Reference Container* at the end or positioned by shortcode; +- Display the **footnotes** *Reference Container* inside a Widget; +- Wide choice of numbering styles; +- Freely configurable and optional backlink symbol; +- Configure the **footnotes’** appearance by dashboard settings and Custom CSS style rules; +- Button in both the Visual and the Text editor to add shortcodes around selection. = Example Usage = -This is an example. Please note, that you can customize the shortcode you want to use. +These are a few examples of possible ways to delimit footnotes: 1. Your awesome text((with an awesome footnote)) 2. Your awesome text[ref]with an awesome footnote[/ref] 3. Your awesome text``with an awesome footnote`` -4. Your awesome text `custom-shortcode` with an awesome footnote `custom-shortcode` +4. Your awesome text`custom-shortcode`with an awesome footnote`custom-shortcode` = Where to get footnotes? = The current version is available on the [WordPress.org plugins platform, Footnotes](https://wordpress.org/plugins/footnotes/). @@ -44,7 +42,7 @@ The current version is available on the [WordPress.org plugins platform, Footnot = Support = Please report feature requests, bugs and other support related questions in the [Footnotes section of WordPress Support Forum](https://wordpress.org/support/plugin/footnotes). -Speak your mind, unload your burdens. Notice how we screwed up big time? Bring it to our attention in the above-mentioned [WordPress Forum](https://wordpress.org/support/plugin/footnotes). +Speak your mind, unload your burden, bring it up, and feel free to [post your rating and review!](https://wordpress.org/support/plugin/footnotes/reviews/). = Development = Development of the plugin is an open process. Latest code is available in the [plugin part of WordPress SVN repository, footnotes/](https://plugins.svn.wordpress.org/footnotes/). @@ -373,11 +371,11 @@ Visit this swift write-up from a **footnotes** user by the name of **Southwest** = 1.6.5 = - Bugfix: Improve widgets registration, thanks to @felipelavinz code contribution. - Update: Fix for deprecated PHP function create_function(), thanks to @psykonevro @daliasued bug reports, thanks to @felipelavinz code contribution. -- Update: The CSS had been modified in order to show the tooltip numbers a little less higher than text -- Bugfix: Fixed error on demo in backend +- Update: The CSS has been modified in order to show the tooltip numbers a little less higher than text +- Bugfix: Dashboard: fix error on demo under the Preview tab. = 1.6.4 = -- Bugfix: The deprecated WP_Widget elements have been replaced +- Update: replace deprecated function WP_Widget() with recommended __construct(), thanks to @dartiss code contribution. - Bugfix: Fixed occasional bug where footnote ordering could be out of sequence = 1.6.3 =