Add explicit returns

lib/Pear/LocalLoop/Schema/Result/Organisation.pm

@@ -146,6 +146,8 @@ sub sqlt_deploy_hook {
     else {
         $pending_field->{default_value} = \"false";
     }
+    
+    return 1;
 }
 
 sub to_bool {

lib/Pear/LocalLoop/Schema/Result/Transaction.pm

@@ -103,6 +103,8 @@ sub sqlt_deploy_hook {
     else {
         $pending_field->{default_value} = \"false";
     }
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Schema/Result/User.pm

@@ -84,6 +84,12 @@ __PACKAGE__->has_many(
     { cascade_copy      => 0, cascade_delete => 0 },
 );
 
+__PACKAGE__->filter_column(
+    is_admin => {
+        filter_to_storage => 'to_bool',
+    }
+);
+
 sub sqlt_deploy_hook {
     my ( $source_instance, $sqlt_table ) = @_;
     my $pending_field = $sqlt_table->get_field('is_admin');
@@ -93,14 +99,10 @@ sub sqlt_deploy_hook {
     else {
         $pending_field->{default_value} = \"false";
     }
+    
+    return 1;
 }
 
-__PACKAGE__->filter_column(
-    is_admin => {
-        filter_to_storage => 'to_bool',
-    }
-);
-
 sub to_bool {
     my ( $self, $val ) = @_;
     my $driver_name =

lib/Pear/LocalLoop/Schema/ResultSet/Entity.pm

@@ -5,7 +5,7 @@ use warnings;
 
 use base 'DBIx::Class::ResultSet';
 
-sub sales { shift->search_related( 'sales', @_ ) }
+sub sales { return shift->search_related( 'sales', @_ ) }
 
 sub create_org {
     my ( $self, $org ) = @_;
@@ -16,6 +16,8 @@ sub create_org {
             type         => 'organisation',
         }
     );
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Schema/ResultSet/Leaderboard.pm

@@ -92,6 +92,8 @@ sub recalculate_all {
             warn "Unrecognised Set";
         }
     }
+    
+    return 1;
 }
 
 sub _recalculate_leaderboard {
@@ -105,6 +107,8 @@ sub _recalculate_leaderboard {
             $lb_result->create_new($date);
         }
     );
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Schema/ResultSet/Organisation.pm

@@ -5,6 +5,6 @@ use warnings;
 
 use base 'DBIx::Class::ResultSet';
 
-sub entity { shift->search_related( 'entity', @_ ) }
+sub entity { return shift->search_related( 'entity', @_ ) }
 
 1;

lib/Pear/LocalLoop/Schema/Script/DeploymentHandler.pm

@@ -207,6 +207,8 @@ sub cmd_write_ddl {
             }
         );
     }
+    
+    return 1;
 }
 
 =head2 install_dh
@@ -225,6 +227,8 @@ sub cmd_install_dh {
             version => $self->version,
         }
     );
+    
+    return 1;
 }
 
 =head2 install
@@ -241,6 +245,8 @@ sub cmd_install {
             version => $self->version,
         }
     );
+    
+    return 1;
 }
 
 =head2 upgrade
@@ -253,6 +259,8 @@ sub cmd_upgrade {
     my ($self) = @_;
 
     $self->dh->upgrade;
+    
+    return 1;
 }
 
 =head1 AUTHOR