Add explicit returns

lib/Pear/LocalLoop/Controller/Admin.pm

@@ -34,6 +34,8 @@ sub home {
             pending => $pending_feedback_rs->count,
         },
     );
+    
+    return 1;
 }
 
 sub auth_login {
@@ -52,6 +54,8 @@ sub auth_login {
               . "]" );
         $c->redirect_to('/admin');
     }
+    
+    return 1;
 }
 
 sub auth_logout {
@@ -59,6 +63,8 @@ sub auth_logout {
 
     $c->logout;
     $c->redirect_to('/admin');
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Controller/Admin/Categories.pm

@@ -12,6 +12,8 @@ sub index {
     my $category_rs = $c->result_set;
     $category_rs->result_class('DBIx::Class::ResultClass::HashRefInflator');
     $c->stash( categories => [ $category_rs->all ] );
+    
+    return 1;
 }
 
 # POST
@@ -43,6 +45,8 @@ sub create {
         $c->result_set->create( { name => $category_name } );
     }
     $c->redirect_to('/admin/categories');
+    
+    return 1;
 }
 
 # GET
@@ -58,6 +62,8 @@ sub read {
         $c->flash( error => 'No Category found' );
         $c->redirect_to('/admin/categories');
     }
+    
+    return 1;
 }
 
 # POST
@@ -95,6 +101,8 @@ sub update {
         $c->flash( error => 'No Category found' );
         $c->redirect_to('/admin/categories');
     }
+    
+    return 1;
 }
 
 # DELETE
@@ -112,6 +120,8 @@ sub delete {
         $c->flash( error => 'No Category found' );
     }
     $c->redirect_to('/admin/categories');
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Controller/Admin/Feedback.pm

@@ -18,6 +18,8 @@ sub index {
         },
     );
     $c->stash( feedback_rs => $feedback_rs );
+    
+    return 1;
 }
 
 sub read {
@@ -32,6 +34,8 @@ sub read {
         $c->flash( error => 'No Feedback found' );
         $c->redirect_to('/admin/feedback');
     }
+    
+    return 1;
 }
 
 sub actioned {
@@ -48,6 +52,8 @@ sub actioned {
         $c->flash( error => 'No Feedback found' );
         $c->redirect_to('/admin/feedback');
     }
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Controller/Admin/Import.pm

@@ -21,6 +21,8 @@ sub index {
         },
     );
     $c->stash( import_rs => $import_rs );
+    
+    return 1;
 }
 
 sub list {
@@ -46,10 +48,14 @@ sub list {
         import_org_rs    => $import_org_rs,
         import_lookup_rs => $import_lookup_rs,
     );
+    
+    return 1;
 }
 
 sub get_add {
     my $c = shift;
+    
+    return 1;
 }
 
 sub post_add {
@@ -147,6 +153,8 @@ sub post_add {
 
     $c->flash( success => 'Created Value Set' );
     $c->redirect_to( '/admin/import/' . $value_set->id );
+    
+    return 1;
 }
 
 sub _csv_flash_error {
@@ -160,6 +168,8 @@ sub _csv_flash_error {
         #csv_data => $c->param('csv'),
         date_format => $c->param('date_format'),
     );
+    
+    return 1;
 }
 
 sub get_user {
@@ -209,6 +219,8 @@ sub get_user {
         lookup    => $lookup_result,
         user_name => $user_name,
     );
+    
+    return 1;
 }
 
 sub get_org {
@@ -258,6 +270,8 @@ sub get_org {
         lookup   => $lookup_result,
         org_name => $org_name,
     );
+    
+    return 1;
 }
 
 sub ignore_value {

lib/Pear/LocalLoop/Controller/Admin/ImportFrom.pm

@@ -15,6 +15,8 @@ sub index {
     ];
 
     $c->app->max_request_size(104857600);
+    
+    return 1;
 }
 
 sub post_suppliers {
@@ -130,6 +132,8 @@ sub org_search {
     );
 
     $c->render( json => \@results );
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Controller/Admin/Organisations.pm

@@ -21,10 +21,14 @@ sub list {
     );
 
     $c->stash( orgs_rs => $orgs_rs, );
+    
+    return 1;
 }
 
 sub add_org {
     my $c = shift;
+    
+    return 1;
 }
 
 sub add_org_submit {
@@ -87,6 +91,8 @@ sub add_org_submit {
             $c->redirect_to( '/admin/organisations/' . $organisation->id );
         }
     };
+    
+    return 1;
 }
 
 sub valid_read {
@@ -112,6 +118,8 @@ sub valid_read {
         transactions => $transactions,
         associations => $assoc,
     );
+    
+    return 1;
 }
 
 sub valid_edit {
@@ -183,6 +191,8 @@ sub valid_edit {
         }
     };
     $c->redirect_to( '/admin/organisations/' . $c->param('id') );
+    
+    return 1;
 }
 
 sub merge_list {
@@ -212,6 +222,8 @@ sub merge_list {
         org_result => $org_result,
         org_rs     => $org_rs,
     );
+    
+    return 1;
 }
 
 sub merge_detail {
@@ -239,6 +251,8 @@ sub merge_detail {
         org_result    => $org_result,
         target_result => $target_result,
     );
+    
+    return 1;
 }
 
 sub merge_confirm {
@@ -295,6 +309,8 @@ sub merge_confirm {
     }
     $c->redirect_to(
         '/admin/organisations/' . $org_id . '/merge/' . $target_id );
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Controller/Admin/Reports.pm

@@ -59,6 +59,8 @@ sub transaction_data {
         json => { json           => { data => $transaction_data } },
         html => { transaction_rs => encode_json($transaction_data) },
     );
+    
+    return 1;
 }
 
 sub pg_or_sqlite {

lib/Pear/LocalLoop/Controller/Admin/Tokens.pm

@@ -12,6 +12,8 @@ sub index {
     my $token_rs = $c->result_set;
     $token_rs->result_class('DBIx::Class::ResultClass::HashRefInflator');
     $c->stash( tokens => [ $token_rs->all ] );
+    
+    return 1;
 }
 
 # POST
@@ -43,6 +45,8 @@ sub create {
         $c->result_set->create( { name => $token_name } );
     }
     $c->redirect_to('/admin/tokens');
+    
+    return 1;
 }
 
 # GET
@@ -58,6 +62,8 @@ sub read {
         $c->flash( error => 'No Token found' );
         $c->redirect_to('/admin/tokens');
     }
+    
+    return 1;
 }
 
 # POST
@@ -89,6 +95,8 @@ sub update {
         $c->flash( error => 'No Token found' );
         $c->redirect_to('/admin/tokens');
     }
+    
+    return 1;
 }
 
 # DELETE
@@ -105,6 +113,8 @@ sub delete {
         $c->flash( error => 'No Token found' );
     }
     $c->redirect_to('/admin/tokens');
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Controller/Admin/Transactions.pm

@@ -66,6 +66,8 @@ sub index {
             count        => $count,
         },
     );
+    
+    return 1;
 }
 
 sub read {
@@ -80,6 +82,8 @@ sub read {
         $c->flash( error => 'No transaction found' );
         $c->redirect_to('/admin/transactions');
     }
+    
+    return 1;
 }
 
 sub image {
@@ -95,6 +99,8 @@ sub image {
     else {
         $c->reply->static('image/no_transaction.jpg');
     }
+    
+    return 1;
 }
 
 sub delete {
@@ -114,6 +120,8 @@ sub delete {
         $c->flash( error => 'No transaction found' );
         $c->redirect_to('/admin/transactions');
     }
+    
+    return 1;
 }
 
 sub pg_or_sqlite {

lib/Pear/LocalLoop/Controller/Admin/Users.pm

@@ -32,6 +32,8 @@ sub index {
         }
     );
     $c->stash( user_rs => $user_rs );
+    
+    return 1;
 }
 
 sub read {
@@ -57,6 +59,8 @@ sub read {
         $c->flash( error => 'No User found' );
         $c->redirect_to('/admin/users');
     }
+    
+    return 1;
 }
 
 sub update {
@@ -189,6 +193,8 @@ sub update {
     }
 
     $c->redirect_to( '/admin/users/' . $id );
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Controller/Api/Auth.pm

@@ -139,6 +139,8 @@ sub post_logout {
             message => 'Logged Out',
         }
     );
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Controller/Api/V1/Supplier/Location.pm

@@ -122,6 +122,8 @@ sub index {
             }
         },
     );
+    
+    return 1;
 }
 
 sub trail_load {
@@ -204,6 +206,8 @@ sub trail_load {
             }
         },
     );
+    
+    return 1;
 }
 
 1;

lib/Pear/LocalLoop/Controller/Root.pm

@@ -7,6 +7,8 @@ sub index {
     #  if ( $c->is_user_authenticated ) {
     #   $c->redirect_to('/home');
     #  }
+    
+    return 1;
 }
 
 sub under {
@@ -28,6 +30,8 @@ sub auth_login {
     else {
         $c->redirect_to('/');
     }
+    
+    return 1;
 }
 
 sub auth_logout {
@@ -35,10 +39,14 @@ sub auth_logout {
 
     $c->logout;
     $c->redirect_to('/');
+    
+    return 1;
 }
 
 sub home {
     my $c = shift;
+    
+    return 1;
 }
 
 1;