Pear-Trading/Foodloop-Server
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Added nicer explosions via try::tiny

Browse source
This commit is contained in:
Finn 2019-07-05 18:44:46 +01:00
parent d1cd30928e
commit afc635fdb4
No known key found for this signature in database
GPG key ID: 7455B4B17685B598
6 changed files with 27 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/Pear/LocalLoop/Import/LCCCsv/Suppliers.pm
View file

@ -1,6 +1,5 @@
package Pear::LocalLoop::Import::LCCCsv::Suppliers;
use Moo;
use Devel::Dwarn;
extends qw/Pear::LocalLoop::Import::LCCCsv/;
@ -15,7 +14,6 @@ sub import_csv {
my ($self) = @_;
my $rows = $self->csv_data;
return $self unless $rows;
foreach my $row ( @{$rows} ) {
$self->_row_to_result($row);
}

20
lib/Pear/LocalLoop/Import/LCCCsv/Transactions.pm
View file

@ -6,19 +6,19 @@ use DateTime::Format::Strptime;
extends qw/Pear::LocalLoop::Import::LCCCsv/;
has '+csv_required_columns' => (
builder => sub { return [ qw/
transaction_id
supplier_id
net_amount
gross_amount
/ ]},
builder => sub { return [ (
'transaction_id',
'supplier_id',
'net_amount',
'vat amount',
'gross_amount',
)]},
);
sub import_csv {
my ($self) = @_;
my $rows = $self->csv_data;
return 0 unless $rows;
my $lcc_org = $self->schema->resultset('Organisation')->find({ name => "Lancashire County Council" });
foreach my $row ( @{$rows} ) {
$self->_row_to_result($row, $lcc_org);
@ -29,10 +29,6 @@ sub import_csv {
sub _row_to_result {
my ( $self, $row, $lcc_org ) = @_;
use Devel::Dwarn;
Dwarn $row;
my $supplier_id = $row->{supplier_id};
my $organisation = $self->schema->resultset('Organisation')->find({
@ -49,7 +45,7 @@ sub _row_to_result {
my $paid_date = ( $row->{paid_date} ? $date_formatter->parse_datetime($row->{paid_date}) : DateTime->today );
# TODO negative values
# TODO negative values are sometimes present
$self->external_result->find_or_create_related('transactions', {
external_id => $row->{transaction_id},
transaction => {