Pear-Trading/Foodloop-Server
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Added user account stuff test and some fixes

Browse source
This commit is contained in:
Finn 2017-08-23 18:42:19 +01:00
parent 4c7836c9f6
commit 9865130666
2 changed files with 149 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
lib/Pear/LocalLoop/Controller/Admin/Users.pm
View file

@ -1,6 +1,8 @@
package Pear::LocalLoop::Controller::Admin::Users;
use Mojo::Base 'Mojolicious::Controller';
use Data::Dumper;
has result_set => sub {
my $c = shift;
return $c->schema->resultset('User');
@ -32,16 +34,19 @@ sub edit {
my $id = $c->param('id');
if ( my $user = $c->result_set->find($id) ) {
$c->stash( user => $user );
} else {
my $user;
unless ( $user = $c->result_set->find($id) ) {
$c->flash( error => 'No User found' );
$c->redirect_to( '/admin/users/' . $id );
return $c->redirect_to( '/admin/users/' . $id );
}
my $validation = $c->validation;
$validation->required('email')->not_in_resultset( 'email', $user->id );
my $not_myself_user_rs = $c->result_set->search({
id => { "!=" => $user->id },
});
$validation->required('email')->email->not_in_resultset( 'email', $not_myself_user_rs );
$validation->required('postcode')->postcode;
$validation->optional('new_password');
@ -62,6 +67,7 @@ sub edit {
if ( defined $user->customer_id ){
try {
$c->schema->txn_do( sub {
$user->customer->update({
full_name => $validation->param('full_name'),
@ -73,10 +79,18 @@ sub edit {
( defined $validation->param('new_password') ? ( password => $validation->param('new_password') ) : () ),
});
});
} finally {
if ( @_ ) {
$c->flash( error => 'Something went wrong Updating the User' );
$c->app->log->warn(Dumper @_);
} else {
$c->flash( success => 'Updated User' );
};
}
}
elsif ( defined $user->organisation_id ) {
try {
$c->schema->txn_do( sub {
$user->organisation->update({
name => $validation->param('name'),
@ -89,7 +103,15 @@ sub edit {
( defined $validation->param('new_password') ? ( password => $validation->param('new_password') ) : () ),
});
});
} finally {
if ( @_ ) {
$c->flash( error => 'Something went wrong Updating the User' );
$c->app->log->warn(Dumper @_);
} else {
$c->flash( success => 'Updated User' );
}
}
};
$c->redirect_to( '/admin/users/' . $id );
}

99
t/admin/user.t Normal file
View file

@ -0,0 +1,99 @@
use Mojo::Base -strict;
use Test::More;
use Mojo::JSON;
use Test::Pear::LocalLoop;
my $framework = Test::Pear::LocalLoop->new;
my $t = $framework->framework;
my $schema = $t->app->schema;
my $user = $schema->resultset('User')->create({
email => 'admin@example.com',
password => 'abc123',
administrator => {},
});
is $schema->resultset('Administrator')->count, 1, 'Admin Created';
my $user1 = {
token => 'a',
full_name => 'Test User1',
display_name => 'Test User1',
email => 'test1@example.com',
postcode => 'LA1 1AA',
password => 'abc123',
year_of_birth => 2006,
};
my $org = {
token => 'e',
email => 'test50@example.com',
name => '7th Heaven',
street_name => 'Slums, Sector 7',
town => 'Midgar',
postcode => 'WC1E 6AD',
password => 'abc123',
};
$schema->resultset('AccountToken')->create({ name => $_->{token} })
for ( $user1, $org );
$framework->register_customer($user1);
$framework->register_organisation($org);
#login to admin
$t->ua->max_redirects(10);
$t->post_ok('/admin', form => {
email => 'admin@example.com',
password => 'abc123',
})->status_is(200);
#Read customer user
$t->get_ok('/admin/users/1/')
->status_is(200);
#Read organisation user
$t->get_ok('/admin/users/2/')
->status_is(200);
#Valid organisation user update
$t->post_ok('/admin/users/1/edit', form => {
email => 'test51@example.com',
new_password => 'abc123',
name => '7th Heaven',
street_name => 'Slums, Sector 7',
town => 'Midgar',
postcode => 'WC1E 6AD',
})->status_is(200)->content_like(qr/Updated User/);
#Failed validation on organisation user from wrong email
$t->post_ok('/admin/users/1/edit', form => {
email => 'test55@example.com',
new_password => 'abc123',
name => '7th Heaven',
street_name => 'Slums, Sector 7',
town => 'Midgar',
postcode => 'WC1E 6AD',
})->content_like(qr/The validation has failed/);
#Failed validation on organisation user from no postcode
$t->post_ok('/admin/users/1/edit', form => {
email => 'test50@example.com',
new_password => 'abc123',
name => '7th Heaven',
street_name => 'Slums, Sector 7',
town => 'Midgar',
})->content_like(qr/The validation has failed/);
#Failed validation on organisation user from no street name
$t->post_ok('/admin/users/1/edit', form => {
email => 'test50@example.com',
new_password => 'abc123',
name => '7th Heaven',
town => 'Midgar',
postcode => 'WC1E 6AD',
})->content_like(qr/The validation has failed/);
done_testing();