Fix builtin homonym linter errors

This commit is contained in:
Rumperuu 2021-03-20 19:03:59 +00:00
parent c5c074903d
commit 758dd9e70f
18 changed files with 52 additions and 38 deletions

View file

@ -216,20 +216,20 @@ sub startup {
my $api_v1_user = $api_v1->under('/user'); my $api_v1_user = $api_v1->under('/user');
$api_v1_user->post('/medals')->to('api-v1-user-medals#index'); $api_v1_user->post('/medals')->to('api-v1-user-medals#idx');
$api_v1_user->post('/points')->to('api-v1-user-points#index'); $api_v1_user->post('/points')->to('api-v1-user-points#idx');
my $api_v1_supplier = $api_v1->under('/supplier'); my $api_v1_supplier = $api_v1->under('/supplier');
$api_v1_supplier->post('/location')->to('api-v1-supplier-location#index'); $api_v1_supplier->post('/location')->to('api-v1-supplier-location#idx');
$api_v1_supplier->post('/location/trail') $api_v1_supplier->post('/location/trail')
->to('api-v1-supplier-location#trail_load'); ->to('api-v1-supplier-location#trail_load');
my $api_v1_org = my $api_v1_org =
$api_v1->under('/organisation')->to('api-v1-organisation#auth'); $api_v1->under('/organisation')->to('api-v1-organisation#auth');
$api_v1_org->post('/graphs')->to('api-v1-organisation-graphs#index'); $api_v1_org->post('/graphs')->to('api-v1-organisation-graphs#idx');
$api_v1_org->post('/snippets')->to('api-v1-organisation-snippets#index'); $api_v1_org->post('/snippets')->to('api-v1-organisation-snippets#idx');
$api_v1_org->post('/payroll')->to('api-organisation#post_payroll_read'); $api_v1_org->post('/payroll')->to('api-organisation#post_payroll_read');
$api_v1_org->post('/payroll/add')->to('api-organisation#post_payroll_add'); $api_v1_org->post('/payroll/add')->to('api-organisation#post_payroll_add');
$api_v1_org->post('/supplier')->to('api-organisation#post_supplier_read'); $api_v1_org->post('/supplier')->to('api-organisation#post_supplier_read');
@ -252,13 +252,13 @@ sub startup {
$api_v1_org->post('/external/lcc_tables') $api_v1_org->post('/external/lcc_tables')
->to('api-external#post_lcc_table_summary'); ->to('api-external#post_lcc_table_summary');
$api_v1_org->post('/pies')->to('api-v1-organisation-pies#index'); $api_v1_org->post('/pies')->to('api-v1-organisation-pies#idx');
my $api_v1_cust = $api_v1->under('/customer')->to('api-v1-customer#auth'); my $api_v1_cust = $api_v1->under('/customer')->to('api-v1-customer#auth');
$api_v1_cust->post('/graphs')->to('api-v1-customer-graphs#index'); $api_v1_cust->post('/graphs')->to('api-v1-customer-graphs#idx');
$api_v1_cust->post('/snippets')->to('api-v1-customer-snippets#index'); $api_v1_cust->post('/snippets')->to('api-v1-customer-snippets#idx');
$api_v1_cust->post('/pies')->to('api-v1-customer-pies#index'); $api_v1_cust->post('/pies')->to('api-v1-customer-pies#idx');
my $admin_routes = $r->under('/admin')->to('admin#under'); my $admin_routes = $r->under('/admin')->to('admin#under');
@ -272,18 +272,18 @@ sub startup {
} }
$admin_routes->get('/home')->to('admin#home'); $admin_routes->get('/home')->to('admin#home');
$admin_routes->get('/tokens')->to('admin-tokens#index'); $admin_routes->get('/tokens')->to('admin-tokens#idx');
$admin_routes->post('/tokens')->to('admin-tokens#create'); $admin_routes->post('/tokens')->to('admin-tokens#create');
$admin_routes->get('/tokens/:id')->to('admin-tokens#read'); $admin_routes->get('/tokens/:id')->to('admin-tokens#get');
$admin_routes->post('/tokens/:id')->to('admin-tokens#update'); $admin_routes->post('/tokens/:id')->to('admin-tokens#update');
$admin_routes->post('/tokens/:id/delete')->to('admin-tokens#delete'); $admin_routes->post('/tokens/:id/delete')->to('admin-tokens#del');
$admin_routes->get('/categories')->to('admin-categories#index'); $admin_routes->get('/categories')->to('admin-categories#idx');
$admin_routes->post('/categories')->to('admin-categories#create'); $admin_routes->post('/categories')->to('admin-categories#create');
$admin_routes->get('/categories/:id')->to('admin-categories#read'); $admin_routes->get('/categories/:id')->to('admin-categories#get');
$admin_routes->post('/categories/:id')->to('admin-categories#update'); $admin_routes->post('/categories/:id')->to('admin-categories#update');
$admin_routes->post('/categories/:id/delete') $admin_routes->post('/categories/:id/delete')
->to('admin-categories#delete'); ->to('admin-categories#del');
$admin_routes->get('/users')->to('admin-users#index'); $admin_routes->get('/users')->to('admin-users#index');
$admin_routes->get('/users/:id')->to('admin-users#read'); $admin_routes->get('/users/:id')->to('admin-users#read');
@ -305,8 +305,8 @@ sub startup {
$admin_routes->post('/organisations/:id/merge/:target_id') $admin_routes->post('/organisations/:id/merge/:target_id')
->to('admin-organisations#merge_confirm'); ->to('admin-organisations#merge_confirm');
$admin_routes->get('/feedback')->to('admin-feedback#index'); $admin_routes->get('/feedback')->to('admin-feedback#idx');
$admin_routes->get('/feedback/:id')->to('admin-feedback#read'); $admin_routes->get('/feedback/:id')->to('admin-feedback#get');
$admin_routes->get('/feedback/:id/actioned')->to('admin-feedback#actioned'); $admin_routes->get('/feedback/:id/actioned')->to('admin-feedback#actioned');
$admin_routes->get('/transactions')->to('admin-transactions#index'); $admin_routes->get('/transactions')->to('admin-transactions#index');
@ -319,7 +319,7 @@ sub startup {
$admin_routes->get('/reports/transactions') $admin_routes->get('/reports/transactions')
->to('admin-reports#transaction_data'); ->to('admin-reports#transaction_data');
$admin_routes->get('/import')->to('admin-import#index'); $admin_routes->get('/import')->to('admin-import#idx');
$admin_routes->get('/import/add')->to('admin-import#get_add'); $admin_routes->get('/import/add')->to('admin-import#get_add');
$admin_routes->post('/import/add')->to('admin-import#post_add'); $admin_routes->post('/import/add')->to('admin-import#post_add');
$admin_routes->get('/import/:set_id')->to('admin-import#list'); $admin_routes->get('/import/:set_id')->to('admin-import#list');
@ -330,7 +330,7 @@ sub startup {
->to('admin-import#ignore_value'); ->to('admin-import#ignore_value');
$admin_routes->get('/import/:set_id/import')->to('admin-import#run_import'); $admin_routes->get('/import/:set_id/import')->to('admin-import#run_import');
$admin_routes->get('/import_from')->to('admin-import_from#index'); $admin_routes->get('/import_from')->to('admin-import_from#idx');
$admin_routes->post('/import_from/suppliers') $admin_routes->post('/import_from/suppliers')
->to('admin-import_from#post_suppliers'); ->to('admin-import_from#post_suppliers');
$admin_routes->post('/import_from/transactions') $admin_routes->post('/import_from/transactions')

View file

@ -6,7 +6,7 @@ has result_set => sub {
return $c->schema->resultset('Category'); return $c->schema->resultset('Category');
}; };
sub index { sub idx {
my $c = shift; my $c = shift;
my $category_rs = $c->result_set; my $category_rs = $c->result_set;
@ -50,7 +50,7 @@ sub create {
} }
# GET # GET
sub read { sub get {
my $c = shift; my $c = shift;
my $id = $c->param('id'); my $id = $c->param('id');
@ -106,7 +106,7 @@ sub update {
} }
# DELETE # DELETE
sub delete { sub del {
my $c = shift; my $c = shift;
my $id = $c->param('id'); my $id = $c->param('id');

View file

@ -6,7 +6,7 @@ has result_set => sub {
return $c->schema->resultset('Feedback'); return $c->schema->resultset('Feedback');
}; };
sub index { sub idx {
my $c = shift; my $c = shift;
my $feedback_rs = $c->result_set->search( my $feedback_rs = $c->result_set->search(
@ -22,7 +22,7 @@ sub index {
return 1; return 1;
} }
sub read { sub get {
my $c = shift; my $c = shift;
my $id = $c->param('id'); my $id = $c->param('id');

View file

@ -9,7 +9,7 @@ has result_set => sub {
return $c->schema->resultset('ImportSet'); return $c->schema->resultset('ImportSet');
}; };
sub index { sub idx {
my $c = shift; my $c = shift;
my $import_rs = $c->result_set->search( my $import_rs = $c->result_set->search(

View file

@ -4,7 +4,7 @@ use Moo;
use Try::Tiny; use Try::Tiny;
use Mojo::File qw/path/; use Mojo::File qw/path/;
sub index { sub idx {
my $c = shift; my $c = shift;
$c->stash->{org_entities} = [ $c->stash->{org_entities} = [
map { { id => $_->entity_id, name => $_->name } } map { { id => $_->entity_id, name => $_->name } }

View file

@ -6,7 +6,7 @@ has result_set => sub {
return $c->schema->resultset('AccountToken'); return $c->schema->resultset('AccountToken');
}; };
sub index { sub idx {
my $c = shift; my $c = shift;
my $token_rs = $c->result_set; my $token_rs = $c->result_set;
@ -50,7 +50,7 @@ sub create {
} }
# GET # GET
sub read { sub get {
my $c = shift; my $c = shift;
my $id = $c->param('id'); my $id = $c->param('id');
@ -100,7 +100,7 @@ sub update {
} }
# DELETE # DELETE
sub delete { sub del {
my $c = shift; my $c = shift;
my $id = $c->param('id'); my $id = $c->param('id');

View file

@ -8,7 +8,9 @@ has result_set => sub {
return $c->schema->resultset('Transaction'); return $c->schema->resultset('Transaction');
}; };
## no critic (Subroutines::ProhibitBuiltinHomonyms)
sub index { sub index {
## use critic
my $c = shift; my $c = shift;
my $pending_transaction_rs = my $pending_transaction_rs =
@ -70,7 +72,9 @@ sub index {
return 1; return 1;
} }
## no critic (Subroutines::ProhibitBuiltinHomonyms)
sub read { sub read {
## use critic
my $c = shift; my $c = shift;
my $id = $c->param('id'); my $id = $c->param('id');
@ -103,7 +107,9 @@ sub image {
return 1; return 1;
} }
## no critic (Subroutines::ProhibitBuiltinHomonyms)
sub delete { sub delete {
## use critic
my $c = shift; my $c = shift;
my $id = $c->param('id'); my $id = $c->param('id');

View file

@ -19,7 +19,9 @@ has organisation_result_set => sub {
return $c->schema->resultset('Organisation'); return $c->schema->resultset('Organisation');
}; };
## no critic (Subroutines::ProhibitBuiltinHomonyms)
sub index { sub index {
## use critic
my $c = shift; my $c = shift;
my $user_rs = $c->user_result_set->search( my $user_rs = $c->user_result_set->search(
@ -36,7 +38,9 @@ sub index {
return 1; return 1;
} }
## no critic (Subroutines::ProhibitBuiltinHomonyms)
sub read { sub read {
## use critic
my $c = shift; my $c = shift;
my $id = $c->param('id'); my $id = $c->param('id');
@ -63,7 +67,9 @@ sub read {
return 1; return 1;
} }
## no critic (Subroutines::ProhibitBuiltinHomonyms)
sub update { sub update {
## use critic
my $c = shift; my $c = shift;
my $id = $c->param('id'); my $id = $c->param('id');

View file

@ -10,7 +10,7 @@ has error_messages => sub {
}; };
}; };
sub index { sub idx {
my $c = shift; my $c = shift;
my $validation = $c->validation; my $validation = $c->validation;

View file

@ -1,7 +1,7 @@
package Pear::LocalLoop::Controller::Api::V1::Customer::Pies; package Pear::LocalLoop::Controller::Api::V1::Customer::Pies;
use Mojo::Base 'Mojolicious::Controller'; use Mojo::Base 'Mojolicious::Controller';
sub index { sub idx {
my $c = shift; my $c = shift;
my $entity = $c->stash->{api_user}->entity; my $entity = $c->stash->{api_user}->entity;

View file

@ -1,7 +1,7 @@
package Pear::LocalLoop::Controller::Api::V1::Customer::Snippets; package Pear::LocalLoop::Controller::Api::V1::Customer::Snippets;
use Mojo::Base 'Mojolicious::Controller'; use Mojo::Base 'Mojolicious::Controller';
sub index { sub idx {
my $c = shift; my $c = shift;
my $entity = $c->stash->{api_user}->entity; my $entity = $c->stash->{api_user}->entity;

View file

@ -10,7 +10,7 @@ has error_messages => sub {
}; };
}; };
sub index { sub idx {
my $c = shift; my $c = shift;
my $validation = $c->validation; my $validation = $c->validation;

View file

@ -1,7 +1,7 @@
package Pear::LocalLoop::Controller::Api::V1::Organisation::Pies; package Pear::LocalLoop::Controller::Api::V1::Organisation::Pies;
use Mojo::Base 'Mojolicious::Controller'; use Mojo::Base 'Mojolicious::Controller';
sub index { sub idx {
my $c = shift; my $c = shift;
my $entity = $c->stash->{api_user}->entity; my $entity = $c->stash->{api_user}->entity;

View file

@ -1,7 +1,7 @@
package Pear::LocalLoop::Controller::Api::V1::Organisation::Snippets; package Pear::LocalLoop::Controller::Api::V1::Organisation::Snippets;
use Mojo::Base 'Mojolicious::Controller'; use Mojo::Base 'Mojolicious::Controller';
sub index { sub idx {
my $c = shift; my $c = shift;
my $entity = $c->stash->{api_user}->entity; my $entity = $c->stash->{api_user}->entity;

View file

@ -47,7 +47,7 @@ has validation_data => sub {
}; };
}; };
sub index { sub idx {
my $c = shift; my $c = shift;
return if $c->validation_error('index'); return if $c->validation_error('index');

View file

@ -2,7 +2,7 @@ package Pear::LocalLoop::Controller::Api::V1::User::Medals;
use Mojo::Base 'Mojolicious::Controller'; use Mojo::Base 'Mojolicious::Controller';
use Mojo::JSON qw/true false/; use Mojo::JSON qw/true false/;
sub index { sub idx {
my $c = shift; my $c = shift;
my $validation = $c->validation; my $validation = $c->validation;

View file

@ -2,7 +2,7 @@ package Pear::LocalLoop::Controller::Api::V1::User::Points;
use Mojo::Base 'Mojolicious::Controller'; use Mojo::Base 'Mojolicious::Controller';
use Mojo::JSON qw/true false/; use Mojo::JSON qw/true false/;
sub index { sub idx {
my $c = shift; my $c = shift;
my $validation = $c->validation; my $validation = $c->validation;

View file

@ -1,7 +1,9 @@
package Pear::LocalLoop::Controller::Root; package Pear::LocalLoop::Controller::Root;
use Mojo::Base 'Mojolicious::Controller'; use Mojo::Base 'Mojolicious::Controller';
## no critic (Subroutines::ProhibitBuiltinHomonyms)
sub index { sub index {
## use critic
my $c = shift; my $c = shift;
# if ( $c->is_user_authenticated ) { # if ( $c->is_user_authenticated ) {